Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NWC NIP-47 spec changes list #380

Open
4 tasks
rolznz opened this issue Jul 31, 2024 · 1 comment
Open
4 tasks

NWC NIP-47 spec changes list #380

rolznz opened this issue Jul 31, 2024 · 1 comment
Assignees
@rolznz

Comments

@rolznz
Copy link
Contributor

rolznz commented Jul 31, 2024 •
edited
Loading

We've made some changes and are tracking them here to one day make PR(s):

  • add metadata to nwc make_invoice (No NIP-47 PR) feat: add metadata field to make_invoice command #357
  • List Transactions
    • consider splitting unpaid into unpaid_outgoing and unpaid_incoming so normal wallets can show only unpaid outgoing transactions
    • include the state of the transaction in all endpoints (settled, pending or failed)
  • add metadata to pay_invoice (no NIP-47 PR) - this metadata can be stored in Alby Hub feat: add metadata property to pay_invoice #792
  • add metadata to get_info call (e.g. for keysend data)
@rolznz rolznz self-assigned this Jul 31, 2024
@rolznz rolznz changed the title NWC spec changes list NWC NIP-47 spec changes list Sep 20, 2024
@rolznz rolznz mentioned this issue Sep 20, 2024
Merged
3 tasks
@rolznz
Copy link
Contributor Author

rolznz commented Nov 20, 2024 •
edited
Loading

Merged!

  • NIP-47 notifications (PR)
    • Add fees_paid to all payment responses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolznz rolznz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rolznz