Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add uncle jim internal app #557

Merged
merged 9 commits into from
Sep 2, 2024
Merged

feat: add uncle jim internal app #557

merged 9 commits into from
Sep 2, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Aug 28, 2024

Closes #489

Fixes some other issues:

  • Gives isolated apps get_info permission (recommended by Bumi to reduce complexity)
  • Removes duplicated toasts
  • Adds loading button for app creation

TODOs:

Updated screenshots:

image

image

Video: https://www.loom.com/share/81dc03e041fc49d2ad54acb219511638

@MoritzKa
Copy link
Contributor

Love it!!!

  • ...powered by your Hub
  • Does it actually contain a link, that Time just needs to click on to connect the wallet to the Alby Account or only the connection secret?

@bumi
Copy link
Contributor

bumi commented Aug 28, 2024

we need to explain there what happens and what people can do there and why.

people come to that page without prior knowledge, so we need to pick them up and guide them through this flow.
what do they want to achieve?

@rolznz
Copy link
Contributor Author

rolznz commented Aug 28, 2024

@MoritzKa

Does it actually contain a link, that Time just needs to click on to connect the wallet to the Alby Account or only the connection secret?

Yes, the link is a special getalby.com link which will automatically attach the wallet to your account. But you must be logged in for it to work

@rolznz
Copy link
Contributor Author

rolznz commented Aug 29, 2024

Updated copy & screenshots

rolznz and others added 6 commits September 2, 2024 11:59
* chore: wg.Add() before go (#559)

* chore: code cleanup (#558)

* Update README.md

Add command to make the install script executable in the instructions.

* feat: add migration card in wallet screen (#555)

* feat: add migration card in wallet screen

* chore: transfer funds if channel exists

* chore: typo

* chore: improve copy

* chore: add transfer funds button

* fix: remove duplicate icon

---------

Co-authored-by: Roland Bewick <roland.bewick@gmail.com>

* chore: run extra workflows on PR (#563)

* chore: run extra workflows on PR

* fix: pull request workflows

* build(deps): bump github.com/nbd-wtf/go-nostr from 0.34.5 to 0.34.10 (#551)

Bumps [github.com/nbd-wtf/go-nostr](https://github.com/nbd-wtf/go-nostr) from 0.34.5 to 0.34.10.
- [Commits](nbd-wtf/go-nostr@v0.34.5...v0.34.10)

---
updated-dependencies:
- dependency-name: github.com/nbd-wtf/go-nostr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump gopkg.in/DataDog/dd-trace-go.v1 from 1.66.0 to 1.67.0 (#552)

Bumps gopkg.in/DataDog/dd-trace-go.v1 from 1.66.0 to 1.67.0.

---
updated-dependencies:
- dependency-name: gopkg.in/DataDog/dd-trace-go.v1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: do not render 0 on withdraw onchain funds page when reserve balance is 0 (#549)

* chore: update fly default kill timeout to ensure app gracefully shuts down (#547)

* feat: app metadata

* fix(wails): parse max length in log output endpoint (#568)

* fix: alby account image and name on transaction list

* fix: vertically center transaction item content

* fix: use slashed zero on wallet balance

* chore: align app image with app name in transaction list

* fix: ensure auth with correct user if refresh token expires (#572)

* fix: do not allow editing name of Alby Account connection

* fix: change "Create Wallet" to "Create Subaccount"

* fix: subaccount copy

* chore: update friends and family app icon

* fix: update app store images (#574)

* fix: update app store images

* chore: update paper scissors hodl and zapplanner icons

* chore: update lume and habla news icons

* chore: resize and compress zapplanner and rps logos

---------

Co-authored-by: Roland Bewick <roland.bewick@gmail.com>

* feat: add new auto channel flow that works with existing channels (#556)

* feat: add new auto channel flow that works with existing channels

* chore: remove "first" from auto channel copy

* feat: new transaction list item design

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Matjaž Lipuš <matjazl@gmail.com>
Co-authored-by: BtcPins <pardus79@gmail.com>
Co-authored-by: Michael Bumann <hello@michaelbumann.com>
Co-authored-by: Adithya Vardhan <imadithyavardhan@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 💯

tACK

@rolznz
Copy link
Contributor Author

rolznz commented Sep 2, 2024

@reneaaron thanks for the improvements!

@rolznz rolznz merged commit d257437 into master Sep 2, 2024
9 checks passed
@rolznz rolznz deleted the feat/uncle-jim branch September 2, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Detail Pages
4 participants