chore: better handle ports on Pi and allow albyhub to run on port 80 #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Sep 4, 2024
| echo "Failed to unpack Alby Hub. Potentially bzip2 is missing" | ||
| echo "Install it with sudo apt-get install bzip2" | ||
| fi | ||
|
|
||
| # Cleanup | ||
| rm server-linux-armv6.tar.bz2 | ||
|
|
||
| # allow albyhub to bind on port 80 | ||
| sudo setcap CAP_NET_BIND_SERVICE=+eip /opt/albyhub/bin/albyhub |
There was a problem hiding this comment.
should this be optional? like how we ask to setup a service?
There was a problem hiding this comment.
any option makes it more complicated and more fragile. Those install scripts suck anyway because everybody wants it to be a bit different and systems are often different.
People also need to know a little bit of what they do.
IF we don't run as root then as far as I understand we need this. otherwise we need to run as root or on a different port.
bumi
force-pushed
the
update-pi-scripts
branch
from
a7e7b62
to
ba39cd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.