fix: use channel balance api in get balances (LND) #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Sep 22, 2024
lnclient/lnd/lnd.go
Outdated
| @@ -858,11 +869,11 @@ func (svc *LNDService) GetBalances(ctx context.Context) (*lnclient.BalancesRespo | |||
| return &lnclient.BalancesResponse{ | |||
| Onchain: *onchainBalance, | |||
| Lightning: lnclient.LightningBalanceResponse{ | |||
| TotalSpendable: totalSpendable, | |||
| TotalReceivable: totalReceivable, | |||
| TotalSpendable: int64(balances.LocalBalance.Msat), | |||
There was a problem hiding this comment.
this does not work - it does not remove the channel reserve.
|
@im-adithya I fixed the balances so they discount the channel reserve, and added the missing calculations (these are useful from settings -> debug tools to check why you cannot make a payment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #644
We recently saw an issue where people saw balance differently in Umbrel, Hub and the Extension
For example:
1 748 499- Umbrel1 747 569- Extension987 439- Hub Node pageThis PR makes the Hub Node page return the same balance as the extension. The difference of 930 between Umbrel and Extension is not solved by this PR as it is because of an unsettled HTLC (again, I suspect that it is an invoice of value 500 sats but this additional 430 sats is cut from the balance and I don't know why that is the case)