Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: firefox suggesting unlock passcode on nostr private keys #2497

Closed
wants to merge 3 commits into from
Closed

fix: firefox suggesting unlock passcode on nostr private keys #2497

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b8e51f
fix: firefox suggesting unlock passcode on nostr private keys
fczuardi Jun 20, 2023
b04c3cb
docs: reference the firefox autocomplete issue on the code comment
fczuardi Jul 4, 2023
b690553
Update src/app/screens/Accounts/Detail/index.tsx
fczuardi Jul 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/app/screens/Accounts/Detail/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,12 @@ function AccountDetail() {
className="mb-4 flex justify-between items-end"
>
<div className="w-7/12">
{/* We use a hidden field to hint Firefox's password manager
that this password field is for an account different
than the unlock passcode (no username)
See: https://github.com/getAlby/lightning-browser-extension/issues/2489
*/}
<input value={accountName} style={{ display: "none" }} />
fczuardi marked this conversation as resolved.
Show resolved Hide resolved
<TextField
id="nostrPrivateKey"
label={t("nostr.private_key.label")}
Expand Down