Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): Add bordered prop and fix wide true size #261

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

diogomateus
Copy link
Collaborator

What this PR does

This PR updates the checkbox component:

  • adds a bordered prop allowing to have a checkbox without the bordered label:
Screenshot 2023-09-05 at 11 03 43
  • fixes the wide prop, making it full width when wide is true. Fixed wide pixel widths should be defined in usage, not at the design system level:
    Before
Screenshot 2023-09-05 at 11 03 29

After
Screenshot 2023-09-05 at 11 03 10

Checklist:

  • I reviewed my own code
  • The changes align with the designs I received
    Or give a reason why this does not apply:
  • I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
    Or give a reason why this does not apply:
  • I have updated the task(s) status on Linear
  • All new media is optimized (images, gifs, videos)

Browser support

My code works in the following browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge

@diogomateus diogomateus merged commit 4b2b562 into main Sep 5, 2023
4 checks passed
@diogomateus diogomateus deleted the diogo/checkbox-bordered-wide branch September 5, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants