Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi-dropzone): [EMU-7000] Fix MultiDropzone cell icon shrinking #286

Closed
wants to merge 1 commit into from

Conversation

diogomateus
Copy link
Collaborator

What this PR does

Before:
Screenshot 2023-12-13 at 09 39 50

After:
Screenshot 2023-12-13 at 09 39 53

Solves:
EMU-7000

How to test?

Please include additional context on how to test this PR.

Checklist:

  • I reviewed my own code
  • The changes align with the designs I received
    Or give a reason why this does not apply:
  • I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
    Or give a reason why this does not apply:
  • I have updated the task(s) status on Linear
  • All new media is optimized (images, gifs, videos)

Browser support

My code works in the following browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge

@talo242
Copy link
Contributor

talo242 commented Dec 13, 2023

I don't think this problem is specific to the Multidropzone component, I think it affects all icons. You can see inside the new PolicyDocuments component that the FileTextIcon is being imported straight from DS.

IMHO the expected behavior is that if you set an explicit size attribute, the icon should remain at that size, without having to set a different minimum size in outer wrappers.

What do you think?

@diogomateus
Copy link
Collaborator Author

I don't think this problem is specific to the Multidropzone component, I think it affects all icons. You can see inside the new PolicyDocuments component that the FileTextIcon is being imported straight from DS.

IMHO the expected behavior is that if you set an explicit size attribute, the icon should remain at that size, without having to set a different minimum size in outer wrappers.

What do you think?

Oh, I see! I didn't realise this was happening, will take a look! Closing this PR for now 👍

@diogomateus diogomateus deleted the diogo/multi-dropzone-icon-shrinking branch June 27, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants