refactor(multidropzone): [SIDE-7] Update MultiDropzone component to have default accept type #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave default accept type
diogomateus
force-pushed
the
diogo/side-7-block-customers-from-uploading-unacceptable-file-types
branch
from
a803530 to
d8ba9d2
Compare
kimkwanka
reviewed
May 21, 2024
| @@ -1,25 +1,41 @@ | |||
| import { Accept } from "react-dropzone"; | |||
|
|
|||
| export enum FileMimeTypes { | |||
| avi = "video/x-msvideo", | |||
There was a problem hiding this comment.
I know, I know 😄
kimkwanka
approved these changes
May 21, 2024
talo242
requested changes
May 21, 2024
| @@ -128,14 +128,14 @@ describe('MultiDropzone component', () => { | |||
| const screen = setup({ accept: 'image' }); | |||
|
|
|||
| expect( | |||
| screen.getByText('Supports HEIC, BMP, JPEG, JPG, PNG') | |||
| screen.getByText('Supports images, videos and documents') | |||
There was a problem hiding this comment.
Shouldn't this show only "images" because we are explicitly adding the { accept: 'image' } object?
It seems like we are dropping the labelling based on the file types. Is that what we want?
There was a problem hiding this comment.
@talo242 Fixed it. For custom accept types you need to provide your own label but for generic image/video/documents it will now show the default label.
diogomateus
force-pushed
the
diogo/side-7-block-customers-from-uploading-unacceptable-file-types
branch
from
815222e to
bc97671
Compare
talo242
approved these changes
May 21, 2024
diogomateus
deleted the
diogo/side-7-block-customers-from-uploading-unacceptable-file-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Updates
MultiDropzonecomponent to:Solves:
SIDE-7
How to test?
Please include additional context on how to test this PR.
Checklist:
Or give a reason why this does not apply:
Or give a reason why this does not apply:
Browser support
My code works in the following browsers: