Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(date-selector): DateSelector component updates #316

Merged
merged 1 commit into from
May 28, 2024

Conversation

diogomateus
Copy link
Collaborator

What this PR does

DateSelector component updates:

  • Moves tests to use getByLabelText instead of getByTestId (but still keeps data-testid as it can be useful for app testing)
  • Adds additional validation to calendar component on clicking
  • Allows configuring input props

How to test?

Please include additional context on how to test this PR.

Checklist:

  • I reviewed my own code
  • The changes align with the designs I received
    Or give a reason why this does not apply:
  • I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
    Or give a reason why this does not apply:
  • I have updated the task(s) status on Linear
  • All new media is optimized (images, gifs, videos)

Browser support

My code works in the following browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge

@diogomateus diogomateus requested a review from talo242 May 21, 2024 10:11
@diogomateus diogomateus force-pushed the diogo/date-selector-updates branch from 9a03475 to b853606 Compare May 21, 2024 10:19
@diogomateus diogomateus merged commit 4e3ea39 into main May 28, 2024
4 checks passed
@diogomateus diogomateus deleted the diogo/date-selector-updates branch May 28, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants