Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CoverageTable): [EPIC-137] Improve CoverageTable #317

Merged
merged 18 commits into from
Jun 10, 2024

Conversation

kimkwanka
Copy link
Contributor

What this PR does

This PR improves the CoverageTable implementation by doing the following:

  • Add hideScrollBarsMobile prop
  • Fix scrollbar hiding killing the mobile view buttons
  • Add props to change detail button captions
  • Truly disable TableArrows buttons to avoid some edge cases
  • Expose onSelectionChanged callback
  • Replace underline links with (i) buttons
  • Expose classNameOverrides and made "sections" into real sections
  • Increase cell text contrast
  • Fixed an issue where uncollapsed sections would overflow on the right
  • Adjust padding and cell default sizes
  • Fix addon card size

Why is this needed?

To have a more streamlined CoverageTable which still offers flexibility.

Solves:
EPIC-137

Checklist:

  • I reviewed my own code
  • The changes align with the designs I received
    Or give a reason why this does not apply:
  • I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
    Or give a reason why this does not apply:
  • I have updated the task(s) status on Linear
  • All new media is optimized (images, gifs, videos)

Browser support

My code works in the following browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge

@kimkwanka kimkwanka requested a review from talo242 June 7, 2024 12:11
@diogomateus
Copy link
Collaborator

My only question is about these two blocks having different widths, is this expected?

Screenshot 2024-06-07 at 15 14 11

@kimkwanka
Copy link
Contributor Author

My only question is about these two blocks having different widths, is this expected?

Screenshot 2024-06-07 at 15 14 11

Yeah it's expected, as that details button just spans the whole container width whereas the sections are as big as their internal content. I'll try to figure out something. Thanks for bringing this up!

@kimkwanka
Copy link
Contributor Author

I exposed the details button's className as well now, so that one can add custom styling. @diogomateus

@kimkwanka kimkwanka merged commit 0c3a835 into main Jun 10, 2024
4 checks passed
@kimkwanka kimkwanka deleted the kim/epic-137-improve-coveragetable branch June 10, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants