Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): [SIDE-637] do not push info button to next column #394

Merged

Conversation

talo242
Copy link
Contributor

@talo242 talo242 commented Sep 20, 2024

What this PR does

This PR updates the <Table /> component to prevent long strings of text to push info buttons:

Before After
Screenshot 2024-09-20 at 10 14 20 Screenshot 2024-09-20 at 10 13 18

Why is this needed?

To keep info buttons on the same column as the content

Solves:
SIDE-637

How to test?

You can check the new behavior on Storybook. You can try and change the text length of the cells content and see how the info button behaves on both mobile and desktop.

Checklist:

  • I reviewed my own code
  • The changes align with the designs I received
    Or give a reason why this does not apply:
  • I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
    Or give a reason why this does not apply:
  • I have updated the task(s) status on Linear
  • All new media is optimized (images, gifs, videos)
    No new media

Browser support

My code works in the following browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge

Copy link
Collaborator

@diogomateus diogomateus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this 🙌

@talo242 talo242 merged commit 1c8bbda into main Sep 20, 2024
4 checks passed
@talo242 talo242 deleted the talo/side-637-table-hides-info-button-when-contents-are-too-long branch September 20, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants