-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write screenshot to file #172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
negiDharmendra
commented
Dec 9, 2019
•
edited
Loading
edited
- Changed default screenshot grabber to write to file and return file path.
- Depricate existing custom screenshot grabber API contract.
- Create a new API contact for custom screenshot grabber to write the screenshot into file and returning file path instead of screenhsot bytes.
0790c7b
to
a4782a8
Compare
…ng screenshots bytes. getgauge/gauge#1476
a4782a8
to
e01085e
Compare
BugDiver
approved these changes
Dec 11, 2019
BugDiver
requested changes
Dec 11, 2019
BugDiver
requested changes
Dec 11, 2019
BugDiver
previously approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.