Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

251 nested dir images #253

Merged
merged 7 commits into from
Mar 6, 2020
Merged

251 nested dir images #253

merged 7 commits into from
Mar 6, 2020

Conversation

sriv
Copy link
Member

@sriv sriv commented Feb 26, 2020

some tests had incorrect expectations (w.r.t file path)

@gaugebot gaugebot bot added the cla-signed label Feb 26, 2020
@gaugebot gaugebot bot requested a review from BugDiver February 26, 2020 09:37
@cyberjaime45
Copy link

cyberjaime45 commented Feb 26, 2020

@sriv I'm still getting no images for failures that happens inside "concepts" logic

If failures happens, for a step inside any specs directory -> works fine
If failures happens for a step inside any concepts directory -> no images

@sriv
Copy link
Member Author

sriv commented Feb 27, 2020

good catch, thanks @cyberjaime45 - working on it

@Debashis9012
Copy link
Contributor

I am getting the below error:

Error occurred while waiting for plugin process to finish. Error : exit status 1 Unable to connect to plugin Html Report 4.0.10. rpc error: code = Unavailable desc = transport is closing

versions:

Commit Hash: ed7b4fd6

Plugins
-------
html-report (4.0.10)
java (0.7.4)
js (2.3.8)```

@sriv
Copy link
Member Author

sriv commented Mar 3, 2020

@Debashis9012 - can you share a project that has this issue?

Also, please check if there are any errors reported in gauge.log

@Debashis9012
Copy link
Contributor

@sriv Kindly find the attached project.
issues251-java.zip

@sriv
Copy link
Member Author

sriv commented Mar 3, 2020

hi @Debashis9012 - I am able to run your project successfully, and see the below stacktrace:

hi there!
# Specification Heading
  ## Vowel counts in single word	 ✔ ✘
        Failed Step: The word "gauge" has "4" vowels.
        Specification: specs/example.spec:16
        Error Message: java.lang.AssertionError: 
        Expecting:
         <4>
        to be equal to:
         <3>
        but was not.
        Stacktrace: 
        StepImplementation.verifyVowelsCountInWord(StepImplementation.java:24)
        java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        java.base/java.lang.reflect.Method.invoke(Method.java:566)
        com.thoughtworks.gauge.execution.MethodExecutor.execute(MethodExecutor.java:38)
        com.thoughtworks.gauge.execution.StepExecutionStage.executeStepMethod(StepExecutionStage.java:76)
        com.thoughtworks.gauge.execution.StepExecutionStage.executeStep(StepExecutionStage.java:69)
        com.thoughtworks.gauge.execution.StepExecutionStage.execute(StepExecutionStage.java:51)
        com.thoughtworks.gauge.execution.AbstractExecutionStage.executeNext(AbstractExecutionStage.java:24)
        com.thoughtworks.gauge.execution.HookExecutionStage.execute(HookExecutionStage.java:43)
        com.thoughtworks.gauge.execution.ExecutionPipeline.start(ExecutionPipeline.java:29)
        com.thoughtworks.gauge.processor.ExecuteStepProcessor.process(ExecuteStepProcessor.java:48)
        com.thoughtworks.gauge.RunnerServiceHandler.executeStep(RunnerServiceHandler.java:115)
        gauge.messages.RunnerGrpc$MethodHandlers.invoke(RunnerGrpc.java:1953)
        io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:172)
        io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:331)
        io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:817)
        io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
        io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
        java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        java.base/java.lang.Thread.run(Thread.java:834)
        
  ## Vowel counts in multiple word	 ✔ ✔

Successfully generated html-report to => /home/steam/Downloads/issues251-java/reports/html-report/index.html

Specifications:	1 executed	0 passed	1 failed	0 skipped
Scenarios:	2 executed	1 passed	1 failed	0 skipped

Total time taken: 2.258s

From your logs, I suspect that your html-report plugin might not be from this branch. Can you please uninstall and install html-report from this branch?

@Debashis9012 Debashis9012 merged commit 77ec935 into master Mar 6, 2020
@Debashis9012
Copy link
Contributor

This PR has been tested and verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants