HTTP-99 Add support for generic json and URL query creator #149
+1,036
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2025
Open
davidradl
force-pushed
the
http99
branch
2 times, most recently
from
d78aa5e to
7c81ffe
Compare
...ndata/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreator.java
Show resolved
Hide resolved
...ndata/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreator.java
Show resolved
Hide resolved
...ndata/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreator.java
Show resolved
Hide resolved
...ndata/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreator.java
Show resolved
Hide resolved
...ndata/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreator.java
Show resolved
Hide resolved
...a/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/getindata/connectors/http/internal/table/lookup/querycreators/PathBean.java
Show resolved
Hide resolved
src/test/java/com/getindata/connectors/http/internal/table/lookup/querycreators/PersonBean.java
Show resolved
Hide resolved
...ava/com/getindata/connectors/http/internal/table/lookup/querycreators/QueryCreatorUtils.java
Show resolved
Hide resolved
...a/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreatorTest.java
Outdated
Show resolved
Hide resolved
|
@maciejmaciejko-gid thanks for the feedback, I have implemented most of it. The formatting is somewhat dictated by the check style. It is especially harsh on new lines. I have left the commits unsquashed as previously requested by @grzegorz8 . |
grzegorz8
reviewed
Apr 22, 2025
...ndata/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreator.java
Show resolved
Hide resolved
...ndata/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreator.java
Show resolved
Hide resolved
...ndata/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreator.java
Show resolved
Hide resolved
...ndata/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreator.java
Show resolved
Hide resolved
...onnectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreatorFactory.java
Show resolved
Hide resolved
...a/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreatorTest.java
Show resolved
Hide resolved
...a/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreatorTest.java
Outdated
Show resolved
Hide resolved
...a/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreatorTest.java
Show resolved
Hide resolved
...ndata/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreator.java
Show resolved
Hide resolved
grzegorz8
reviewed
May 2, 2025
...ndata/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreator.java
Show resolved
Hide resolved
| @SuppressWarnings({"checkstyle:RegexpSingleline", "checkstyle:LineLength"}) | ||
| public class GenericJsonAndUrlQueryCreatorFactory implements LookupQueryCreatorFactory { | ||
| private static final long serialVersionUID = 1L; | ||
| private static final Logger log = |
There was a problem hiding this comment.
I still see custom definition of log instead of @Slf4j.
...ctors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreatorFactoryTest.java
Outdated
Show resolved
Hide resolved
...a/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreatorTest.java
Show resolved
Hide resolved
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
Signed-off-by: davidradl <david_radley@uk.ibm.com>
|
@grzegorz8 @maciejmaciejko-gid I think I have addressed everything. LGTM. |
grzegorz8
approved these changes
May 16, 2025
|
@grzegorz8 I suggest we leave this to the end of the 21st of May for @maciejmaciejko-gid and @kristoffSC to provide any more feedback , we get approves or no responses then we should merge then. WDYT? |
maciejmaciejko-gid
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for generic json and URL query creator. This is a generic json query creator, aiming to allow the common json requests to be constructed using table configuration, rather than requiring custom java code to be written.
Resolves
HTTP99PR Checklist