Preview links of some files aren't working

[samlinck]

Description

The preview link for some files appears as a button instead of a standard link. As a result, clicking it does nothing. However, the file can be accessed by manually copying and pasting the URL.

Initially, I thought it was a Dreamform bug since the file was uploaded through Dreamform. However, after further testing, we found that some files not uploaded via Dreamform also have this issue. Referring issue

Expected behavior

The preview link opens the file url in a new tab.

Screenshots
The file I have problems with

The preview button html

To reproduce

1. Go to a file
2. Try to click on the preview link

Your setup

Kirby Version
4.4.1

Console output

Your system (please complete the following information)

• Device: Macbook Pro
• OS: MacOs 14.5
• Browser: Chrome
• Version: 130.0.6723.117 (Official Build) (arm64)

Additional context

[distantnative]

Can you reproduce it with a fresh starter kit? Or any actual description to reproduce it? Cause the steps you describe just work fine with the demo kit: https://getkirby.com/try

[samlinck]

Hi sorry for the missing info. I can't reproduce the issue with files uploaded via the panel. But the plugin author does have the issue with other files uploaded via the panel.

1. Install the starterkit
2. Install Dreamform
3. Make a form with an upload field
4. Upload an image (I tried jpg, png, pdf, gif, mp4) via the form
5. Visit the submission in the panel
6. Go to file in the panel
7. Try to preview file (This doesn't work)

[dominiklaube]

I can reproduce the issue as described here. The problem occurs when uploading a file to a page with a blueprint that has the preview permission set to false.

What would be the correct solution here? Sometimes, you may want to disable the page preview while still allowing the file preview.

I also noticed in the screenshot that the button classname "k-file-view-options" might be incorrect and should perhaps be "k-file-view-preview" instead.

[nilsmielke]

Can confirm @dominiklaube’s findings.
Setting preview: true in the page template of the page the file was loaded into, fixes the file preview—as a temporary fix, that is.

[distantnative]

@dominiklaube @nilsmielke thanks for figuring out how to reproduce the issue, very helpful. I can replicate it as well.

[distantnative]

It's caused by this commit: bc2e9fc

My question to you, @samlinck @dominiklaube @nilsmielke, would be if the commit has the right intention and the file preview should also be gone if the parent page preview is disabled (and we just need to fix the UI to not show the button) or if you have use cases where this behavior is problematic and the file preview should be independent.

[nilsmielke]

@distantnative In my use case, the file preview is intended in a page, that is not previewable. The page only holds information, that is not displayed on a single page basis in the frontend, thus, the preview is futile. Still, the file needs to be downloadable from the panel.