-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECS] Force New Deployment #8232
Conversation
@bblommers ready for review |
Not sure what's up with the linting errors. MyPy ran without issue locally, and all of the errors are from services I didn't touch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @armichaud! This looks all good - can you rebase the PR on master? That should fix the build (now that #8231 is merged)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8232 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 1158 1158
Lines 100101 100108 +7
=======================================
+ Hits 94644 94651 +7
Misses 5457 5457
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@bblommers Ready for launch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you @armichaud!
Fixes #8219