Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECS] Force New Deployment #8232

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

armichaud
Copy link
Contributor

Fixes #8219

@armichaud
Copy link
Contributor Author

@bblommers ready for review

@armichaud armichaud marked this pull request as ready for review October 15, 2024 03:14
@armichaud
Copy link
Contributor Author

Not sure what's up with the linting errors. MyPy ran without issue locally, and all of the errors are from services I didn't touch

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @armichaud! This looks all good - can you rebase the PR on master? That should fix the build (now that #8231 is merged)

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (947004f) to head (2ed45cb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8232   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files        1158     1158           
  Lines      100101   100108    +7     
=======================================
+ Hits        94644    94651    +7     
  Misses       5457     5457           
Flag Coverage Δ
servertests 28.88% <0.00%> (-0.01%) ⬇️
unittests 94.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@armichaud
Copy link
Contributor Author

@bblommers Ready for launch

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @armichaud!

@bblommers bblommers added this to the 5.0.18 milestone Oct 16, 2024
@bblommers bblommers merged commit 9dbd017 into getmoto:master Oct 16, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ecs update_service forceNewDeployment should update service.deployments[0]["createdAt"]
2 participants