From d21a750ae1192888d29c89c85d37883ebc2fd226 Mon Sep 17 00:00:00 2001 From: leonardodrigo Date: Thu, 13 Oct 2022 14:27:03 -0300 Subject: [PATCH 1/4] adding parquet format in s3 settings --- modules/endpoints/main.tf | 1 + 1 file changed, 1 insertion(+) diff --git a/modules/endpoints/main.tf b/modules/endpoints/main.tf index 2ea0d8d..91fce23 100644 --- a/modules/endpoints/main.tf +++ b/modules/endpoints/main.tf @@ -29,6 +29,7 @@ resource "aws_dms_endpoint" "this" { csv_delimiter = lookup(s3.value, "csv_delimiter", ",") csv_row_delimiter = lookup(s3.value, "csv_row_delimiter", null) date_partition_enabled = lookup(s3.value, "date_partition_enabled", false) + data_format = lookup(s3.value, "data_format", "csv") } } From 73c79736bedb61fab59dd5f34d97d87c6702708c Mon Sep 17 00:00:00 2001 From: leonardodrigo Date: Thu, 13 Oct 2022 15:07:15 -0300 Subject: [PATCH 2/4] adding new parameters in s3 settings --- modules/endpoints/main.tf | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/modules/endpoints/main.tf b/modules/endpoints/main.tf index 91fce23..2183418 100644 --- a/modules/endpoints/main.tf +++ b/modules/endpoints/main.tf @@ -22,15 +22,21 @@ resource "aws_dms_endpoint" "this" { content { bucket_name = s3.value["bucket_name"] - bucket_folder = lookup(s3.value, "bucket_folder", null) - external_table_definition = lookup(s3.value, "external_table_definition", null) - service_access_role_arn = lookup(s3.value, "service_access_role_arn", null) - compression_type = lookup(s3.value, "compression_type", "NONE") - csv_delimiter = lookup(s3.value, "csv_delimiter", ",") - csv_row_delimiter = lookup(s3.value, "csv_row_delimiter", null) - date_partition_enabled = lookup(s3.value, "date_partition_enabled", false) - data_format = lookup(s3.value, "data_format", "csv") - } + bucket_folder = lookup(s3.value, "bucket_folder", null) + external_table_definition = lookup(s3.value, "external_table_definition", null) + service_access_role_arn = lookup(s3.value, "service_access_role_arn", null) + compression_type = lookup(s3.value, "compression_type", "NONE") + csv_delimiter = lookup(s3.value, "csv_delimiter", ",") + csv_row_delimiter = lookup(s3.value, "csv_row_delimiter", null) + date_partition_enabled = lookup(s3.value, "date_partition_enabled", false) + data_format = lookup(s3.value, "data_format", "csv") + date_partition_delimiter = lookup(s3.value, "date_partition_delimiter", "NONE") + date_partition_sequence = lookup(s3.value, "date_partition_sequence", "YYYYMMDD") + include_op_for_full_load = lookup(s3.value, "include_op_for_full_load", false) + parquet_timestamp_in_millisecond = lookup(s3.value, "parquet_timestamp_in_millisecond", false) + parquet_version = lookup(s3.value, "parquet_version", "parquet-1-0") + enable_statistics = lookup(s3.value, "enable_statistics", true) + preserve_transactions = lookup(s3.value, "preserve_transactions", false) } dynamic "mongodb_settings" { From 23936dd493c0c12bdae6f9f5051bbd888d0541d6 Mon Sep 17 00:00:00 2001 From: leonardodrigo Date: Thu, 13 Oct 2022 15:40:21 -0300 Subject: [PATCH 3/4] fixing end block in main file --- modules/endpoints/main.tf | 1 + 1 file changed, 1 insertion(+) diff --git a/modules/endpoints/main.tf b/modules/endpoints/main.tf index 2183418..f47cbac 100644 --- a/modules/endpoints/main.tf +++ b/modules/endpoints/main.tf @@ -90,4 +90,5 @@ resource "aws_dms_endpoint" "this" { } tags = var.tags + } } From 5898b1ec577696ef38100f22e27fc88ddab1d2ff Mon Sep 17 00:00:00 2001 From: leonardodrigo Date: Thu, 13 Oct 2022 16:08:07 -0300 Subject: [PATCH 4/4] making adjustments in blocks --- modules/endpoints/main.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/endpoints/main.tf b/modules/endpoints/main.tf index f47cbac..4836920 100644 --- a/modules/endpoints/main.tf +++ b/modules/endpoints/main.tf @@ -37,6 +37,7 @@ resource "aws_dms_endpoint" "this" { parquet_version = lookup(s3.value, "parquet_version", "parquet-1-0") enable_statistics = lookup(s3.value, "enable_statistics", true) preserve_transactions = lookup(s3.value, "preserve_transactions", false) + } } dynamic "mongodb_settings" { @@ -90,5 +91,4 @@ resource "aws_dms_endpoint" "this" { } tags = var.tags - } }