From 4098bc302ca942d7ec912fb22f81fa2bb2b4dbe0 Mon Sep 17 00:00:00 2001 From: Wolfgang Traylor Date: Wed, 29 Jul 2020 04:43:39 +0200 Subject: [PATCH] cli: tweak installer to allow spaces in step IDs (#897) For the script that gets generated by the installer, the call to `docker` must receive the command-line arguments verbatim, including quotes. Therefore `$@` needs to be quoted. Without quotes (before): $ popper run -f wf.yml "first step" would execute: $ docker run <...> getpopper/popper:v2.7.0 run -f wf.yml first step With quotes (after fix): $ docker run <...> getpopper/popper:v2.7.0 run -f wf.yml "first step" [skip ci] --- install.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install.sh b/install.sh index 48143eee9..c4f53b6bd 100644 --- a/install.sh +++ b/install.sh @@ -45,7 +45,7 @@ docker run --rm -ti \ --volume "$PWD":"$PWD" \ --workdir "$PWD" \ --env-file /tmp/.envfile \ - getpopper/popper:v2.7.0 $@ + getpopper/popper:v2.7.0 "$@" EOF if [ "$?" -eq 0 ]; then