Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux install script uses a symlink #2032

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Linux install script uses a symlink #2032

merged 2 commits into from
Apr 27, 2022

Conversation

tamirkamara
Copy link
Contributor

@tamirkamara tamirkamara commented Apr 24, 2022 •
edited
Loading

What does this change

Install on Linux saves the binary in PORTER_HOME and is referenced by a symlink in the runtimes directory

What issue does it fix

Closes #2031

Notes for the reviewer

Per the discussion here: #2014

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@tamirkamara
Use a symlink in a linux install
9a19346 
Signed-off-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
@tamirkamara
Update CONTRIBUTORS.md
0a31462 
Signed-off-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
@tamirkamara tamirkamara force-pushed the fix/linux-install-symlink branch from a68f8d9 to 0a31462 Compare April 24, 2022 09:56
VinozzZ
VinozzZ approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carolynvs
Copy link
Member

Thanks for the fix, @tamirkamara!

@carolynvs carolynvs merged commit 59d55d3 into getporter:main Apr 27, 2022
@carolynvs carolynvs mentioned this pull request May 2, 2022
Closed
@carolynvs carolynvs mentioned this pull request May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinozzZ VinozzZ VinozzZ approved these changes

@carolynvs carolynvs carolynvs approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@vdice vdice Awaiting requested review from vdice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux install script duplicates the binary
3 participants
@tamirkamara @carolynvs @VinozzZ