From 34da15fd6a67cac25fa5c8907297bce12a0a4db0 Mon Sep 17 00:00:00 2001
From: Ran Byron <ranbena@gmail.com>
Date: Mon, 4 Mar 2019 21:51:48 +0200
Subject: [PATCH] Migrated AddTextboxDialog to AntD (#3524)

---
 .../dashboards/AddTextboxDialog.jsx           | 195 +++++++-----------
 .../dashboards/AddTextboxDialog.less          |  18 ++
 .../components/dashboards/AddWidgetDialog.jsx |   2 +-
 client/app/pages/dashboards/dashboard.js      |  45 ++--
 4 files changed, 123 insertions(+), 137 deletions(-)
 create mode 100644 client/app/components/dashboards/AddTextboxDialog.less

diff --git a/client/app/components/dashboards/AddTextboxDialog.jsx b/client/app/components/dashboards/AddTextboxDialog.jsx
index 4a92c0793f..c7424293c1 100644
--- a/client/app/components/dashboards/AddTextboxDialog.jsx
+++ b/client/app/components/dashboards/AddTextboxDialog.jsx
@@ -2,72 +2,49 @@ import { markdown } from 'markdown';
 import { debounce } from 'lodash';
 import React from 'react';
 import PropTypes from 'prop-types';
-import { react2angular } from 'react2angular';
+import Modal from 'antd/lib/modal';
+import Input from 'antd/lib/input';
+import Tooltip from 'antd/lib/tooltip';
+import Divider from 'antd/lib/divider';
+import { wrap as wrapDialog, DialogPropType } from '@/components/DialogWrapper';
 import { toastr } from '@/services/ng';
-import { Widget } from '@/services/widget';
+
+import './AddTextboxDialog.less';
 
 class AddTextboxDialog extends React.Component {
   static propTypes = {
-    dashboard: PropTypes.object, // eslint-disable-line react/forbid-prop-types
-    close: PropTypes.func,
-    dismiss: PropTypes.func,
-  };
-
-  static defaultProps = {
-    dashboard: null,
-    close: () => {},
-    dismiss: () => {},
+    dashboard: PropTypes.object.isRequired, // eslint-disable-line react/forbid-prop-types
+    dialog: DialogPropType.isRequired,
+    onConfirm: PropTypes.func.isRequired,
   };
 
-  constructor(props) {
-    super(props);
-    this.state = {
-      saveInProgress: false,
-      text: '',
-      preview: '',
-    };
+  state = {
+    saveInProgress: false,
+    text: '',
+    preview: '',
+  }
 
-    const updatePreview = debounce(() => {
-      const text = this.state.text;
-      this.setState({
-        preview: markdown.toHTML(text),
-      });
-    }, 100);
+  updatePreview = debounce(() => {
+    const text = this.state.text;
+    this.setState({
+      preview: markdown.toHTML(text),
+    });
+  }, 100);
 
-    this.onTextChanged = (event) => {
-      this.setState({ text: event.target.value });
-      updatePreview();
-    };
-  }
+  onTextChanged = (event) => {
+    this.setState({ text: event.target.value });
+    this.updatePreview();
+  };
 
   saveWidget() {
-    const dashboard = this.props.dashboard;
-
     this.setState({ saveInProgress: true });
 
-    const widget = new Widget({
-      visualization_id: null,
-      dashboard_id: dashboard.id,
-      options: {
-        isHidden: false,
-        position: {},
-      },
-      visualization: null,
-      text: this.state.text,
-    });
-
-    const position = dashboard.calculateNewWidgetPosition(widget);
-    widget.options.position.col = position.col;
-    widget.options.position.row = position.row;
-
-    widget
-      .save()
+    this.props.onConfirm(this.state.text)
       .then(() => {
-        dashboard.widgets.push(widget);
-        this.props.close();
+        this.props.dialog.close();
       })
       .catch(() => {
-        toastr.error('Widget can not be added');
+        toastr.error('Widget could not be added');
       })
       .finally(() => {
         this.setState({ saveInProgress: false });
@@ -75,81 +52,53 @@ class AddTextboxDialog extends React.Component {
   }
 
   render() {
-    return (
-      <div>
-        <div className="modal-header">
-          <button
-            type="button"
-            className="close"
-            disabled={this.state.saveInProgress}
-            aria-hidden="true"
-            onClick={this.props.dismiss}
-          >
-            &times;
-          </button>
-          <h4 className="modal-title">Add Textbox</h4>
-        </div>
-        <div className="modal-body">
-          <div className="form-group m-b-0">
-            <textarea
-              className="form-control resize-vertical"
-              style={{ minMeight: '100px' }}
-              rows="5"
-              value={this.state.text}
-              onChange={this.onTextChanged}
-            />
-          </div>
-          <div
-            ng-show="$ctrl.text"
-            className="m-t-15"
-          >
-            <strong>Preview:</strong>
-            <p
-              dangerouslySetInnerHTML={{ __html: this.state.preview }} // eslint-disable-line react/no-danger
-              className="word-wrap-break"
-            />
-          </div>
-        </div>
+    const { dialog } = this.props;
 
-        <div className="modal-footer">
-          <button
-            type="button"
-            className="btn btn-default"
-            disabled={this.state.saveInProgress}
-            onClick={this.props.dismiss}
-          >
-            Close
-          </button>
-          <button
-            type="button"
-            className="btn btn-primary"
-            disabled={this.state.saveInProgress}
-            onClick={() => this.saveWidget()}
-          >
-            Add to Dashboard
-          </button>
+    return (
+      <Modal
+        {...dialog.props}
+        title="Add Textbox"
+        onOk={() => this.saveWidget()}
+        okButtonProps={{
+          loading: this.state.saveInProgress,
+          disabled: !this.state.text,
+        }}
+        okText="Add to Dashboard"
+        width={500}
+      >
+        <div className="add-textbox">
+          <Input.TextArea
+            className="resize-vertical"
+            rows="5"
+            value={this.state.text}
+            onChange={this.onTextChanged}
+            autoFocus
+            placeholder="This is where you write some text"
+          />
+          <small>
+            Supports basic{' '}
+            <a
+              target="_blank"
+              rel="noopener noreferrer"
+              href="https://www.markdownguide.org/cheat-sheet/#basic-syntax"
+            >
+              <Tooltip title="Markdown guide opens in new window">Markdown</Tooltip>
+            </a>.
+          </small>
+          {this.state.text && (
+            <React.Fragment>
+              <Divider dashed />
+              <strong className="preview-title">Preview:</strong>
+              <p
+                dangerouslySetInnerHTML={{ __html: this.state.preview }} // eslint-disable-line react/no-danger
+                className="preview"
+              />
+            </React.Fragment>
+          )}
         </div>
-      </div>
+      </Modal>
     );
   }
 }
 
-export default function init(ngModule) {
-  ngModule.component('addTextboxDialog', {
-    template: `
-      <add-textbox-dialog-impl 
-        dashboard="$ctrl.resolve.dashboard"
-        close="$ctrl.close"
-        dismiss="$ctrl.dismiss"
-      ></add-textbox-dialog-impl>
-    `,
-    bindings: {
-      resolve: '<',
-      close: '&',
-      dismiss: '&',
-    },
-  });
-  ngModule.component('addTextboxDialogImpl', react2angular(AddTextboxDialog));
-}
-
-init.init = true;
+export default wrapDialog(AddTextboxDialog);
diff --git a/client/app/components/dashboards/AddTextboxDialog.less b/client/app/components/dashboards/AddTextboxDialog.less
new file mode 100644
index 0000000000..b5deadd133
--- /dev/null
+++ b/client/app/components/dashboards/AddTextboxDialog.less
@@ -0,0 +1,18 @@
+.add-textbox {
+  small {
+    display: block;
+    margin-top: 4px;
+  }
+
+  .preview {
+    padding: 9px 9px 1px;
+    background-color: #f7f7f7;
+    margin-top: 8px;
+    word-wrap: break-word
+  }
+
+  .preview-title {
+    display: block;
+    margin-top: -5px;
+  }
+}
\ No newline at end of file
diff --git a/client/app/components/dashboards/AddWidgetDialog.jsx b/client/app/components/dashboards/AddWidgetDialog.jsx
index 898d0ffcfe..f25fdc1f5c 100644
--- a/client/app/components/dashboards/AddWidgetDialog.jsx
+++ b/client/app/components/dashboards/AddWidgetDialog.jsx
@@ -84,7 +84,7 @@ class AddWidgetDialog extends React.Component {
         this.props.dialog.close();
       })
       .catch(() => {
-        toastr.error('Widget can not be added');
+        toastr.error('Widget could not be added');
       })
       .finally(() => {
         this.setState({ saveInProgress: false });
diff --git a/client/app/pages/dashboards/dashboard.js b/client/app/pages/dashboards/dashboard.js
index 0909a9bae0..6069ed9e78 100644
--- a/client/app/pages/dashboards/dashboard.js
+++ b/client/app/pages/dashboards/dashboard.js
@@ -11,6 +11,8 @@ import { durationHumanize } from '@/filters';
 import template from './dashboard.html';
 import ShareDashboardDialog from './ShareDashboardDialog';
 import AddWidgetDialog from '@/components/dashboards/AddWidgetDialog';
+import AddTextboxDialog from '@/components/dashboards/AddTextboxDialog';
+
 import './dashboard.less';
 
 function isWidgetPositionChanged(oldPosition, newPosition) {
@@ -325,25 +327,40 @@ function DashboardCtrl(
   };
 
   this.showAddTextboxDialog = () => {
-    $uibModal
-      .open({
-        component: 'addTextboxDialog',
-        resolve: {
-          dashboard: () => this.dashboard,
-        },
-      })
-      .result.then(this.onWidgetAdded);
+    AddTextboxDialog.showModal({
+      dashboard: this.dashboard,
+      onConfirm: this.addTextbox,
+    });
+  };
+
+  this.addTextbox = (text) => {
+    const widget = new Widget({
+      dashboard_id: this.dashboard.id,
+      options: {
+        isHidden: false,
+        position: {},
+      },
+      text,
+      visualization: null,
+      visualization_id: null,
+    });
+
+    const position = this.dashboard.calculateNewWidgetPosition(widget);
+    widget.options.position.col = position.col;
+    widget.options.position.row = position.row;
+
+    return widget.save()
+      .then(() => {
+        this.dashboard.widgets.push(widget);
+        this.onWidgetAdded();
+      });
   };
 
   this.showAddWidgetDialog = () => {
     AddWidgetDialog.showModal({
       dashboard: this.dashboard,
       onConfirm: this.addWidget,
-    })
-      .result.then(() => {
-        this.onWidgetAdded();
-        $scope.$applyAsync();
-      });
+    });
   };
 
   this.addWidget = (selectedVis, parameterMappings) => {
@@ -371,6 +388,7 @@ function DashboardCtrl(
     return Promise.all(widgetsToSave.map(w => w.save()))
       .then(() => {
         this.dashboard.widgets.push(widget);
+        this.onWidgetAdded();
       });
   };
 
@@ -381,6 +399,7 @@ function DashboardCtrl(
     if (_.isObject(widget)) {
       return widget.save();
     }
+    $scope.$applyAsync();
   };
 
   this.removeWidget = (widgetId) => {