From 0be05f970ce40d481a5d3a5154a9196918030a33 Mon Sep 17 00:00:00 2001 From: Pierre Massat Date: Wed, 14 Sep 2022 12:43:36 -0700 Subject: [PATCH 1/3] fix(profiling): Generate a new profile ID when splitting for multiple transactions --- relay-profiling/src/android.rs | 1 + relay-profiling/src/cocoa.rs | 1 + 2 files changed, 2 insertions(+) diff --git a/relay-profiling/src/android.rs b/relay-profiling/src/android.rs index c75167511b..1b8f259f09 100644 --- a/relay-profiling/src/android.rs +++ b/relay-profiling/src/android.rs @@ -140,6 +140,7 @@ pub fn expand_android_profile(payload: &[u8]) -> Result>, ProfileErr for transaction in &profile.transactions { let mut new_profile = profile.clone(); + new_profile.profile_id = EventId::new(); new_profile.set_transaction(transaction); new_profile.transactions.clear(); diff --git a/relay-profiling/src/cocoa.rs b/relay-profiling/src/cocoa.rs index 6358cafd2b..48fea64449 100644 --- a/relay-profiling/src/cocoa.rs +++ b/relay-profiling/src/cocoa.rs @@ -181,6 +181,7 @@ pub fn expand_cocoa_profile(payload: &[u8]) -> Result>, ProfileError for transaction in &profile.transactions { let mut new_profile = profile.clone(); + new_profile.profile_id = EventId::new(); new_profile.set_transaction(transaction); new_profile.transactions.clear(); From f1c8ff71281f5fe4f06c2451fefbb2bc4729da23 Mon Sep 17 00:00:00 2001 From: Pierre Massat Date: Wed, 14 Sep 2022 12:48:22 -0700 Subject: [PATCH 2/3] Add PR to change log entry --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0a5b1765ce..5916535d23 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,7 +24,7 @@ - Add a "invalid_replay" discard reason for invalid replay events. ([#1455](https://github.com/getsentry/relay/pull/1455)) - Add rate limiters for replays and replay recordings. ([#1456](https://github.com/getsentry/relay/pull/1456)) - Use the different configuration for billing outcomes when specified. ([#1461](https://github.com/getsentry/relay/pull/1461)) -- Support profiles tagged for many transactions. ([#1444](https://github.com/getsentry/relay/pull/1444)), ([#1463](https://github.com/getsentry/relay/pull/1463)), ([#1464](https://github.com/getsentry/relay/pull/1464)) +- Support profiles tagged for many transactions. ([#1444](https://github.com/getsentry/relay/pull/1444)), ([#1463](https://github.com/getsentry/relay/pull/1463)), ([#1464](https://github.com/getsentry/relay/pull/1464)), ([#1473](https://github.com/getsentry/relay/pull/1473)) - Track metrics for changes to the transaction name and DSC propagations. ([#1466](https://github.com/getsentry/relay/pull/1466)) - Simplify the ingestion path to reduce endpoint response times. ([#1416](https://github.com/getsentry/relay/issues/1416), [#1429](https://github.com/getsentry/relay/issues/1429), [#1431](https://github.com/getsentry/relay/issues/1431)) - Update the internal service architecture for the store and outcome services. ([#1405](https://github.com/getsentry/relay/pull/1405), [#1415](https://github.com/getsentry/relay/issues/1415), [#1421](https://github.com/getsentry/relay/issues/1421), [#1441](https://github.com/getsentry/relay/issues/1441), [#1457](https://github.com/getsentry/relay/issues/1457)) From 3fab1b659400f3f9f9aabb3fc5aebe7b9c4ea12c Mon Sep 17 00:00:00 2001 From: Pierre Massat Date: Mon, 19 Sep 2022 04:38:18 -0700 Subject: [PATCH 3/3] Fix changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b78b58121e..bd56f3be3b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## Unreleased +**Internal**: + - Generate a new profile ID when splitting a profile for multiple transactions. ([#1473](https://github.com/getsentry/relay/pull/1473)) ## 22.9.0