diff --git a/CHANGELOG.md b/CHANGELOG.md index 33b0258ee0..5956ecb368 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ - Add `lock` attribute to the frame protocol. ([#2171](https://github.com/getsentry/relay/pull/2171)) - Reject profiles longer than 30s. ([#2168](https://github.com/getsentry/relay/pull/2168)) - Change default topic for transaction metrics to `ingest-performance-metrics`. ([#2180](https://github.com/getsentry/relay/pull/2180)) +- Add Firefox "dead object" error to browser extension filter ([#2215](https://github.com/getsentry/relay/pull/2215)) **Internal**: diff --git a/relay-filter/src/browser_extensions.rs b/relay-filter/src/browser_extensions.rs index cb2639b8ba..e49df3718f 100644 --- a/relay-filter/src/browser_extensions.rs +++ b/relay-filter/src/browser_extensions.rs @@ -40,7 +40,10 @@ static EXTENSION_EXC_VALUES: Lazy = Lazy::new(|| { plugin\.setSuspendState\sis\snot\sa\sfunction| # Chrome extension message passing failure Extension\scontext\sinvalidated| - webkit-masked-url: + webkit-masked-url:| + # Firefox message when an extension tries to modify a no-longer-existing DOM node + # See https://blog.mozilla.org/addons/2012/09/12/what-does-cant-access-dead-object-mean/ + can't\saccess\sdead\sobject "#, ) .expect("Invalid browser extensions filter (Exec Vals) Regex") @@ -252,6 +255,7 @@ mod tests { "plugin.setSuspendState is not a function", "Extension context invalidated", "useless error webkit-masked-url: please filter", + "TypeError: can't access dead object because dead stuff smells bad", ]; for exc_value in &exceptions { @@ -260,7 +264,7 @@ mod tests { assert_ne!( filter_result, Ok(()), - "Event filter not recognizing events with known values {exc_value}" + "Event filter not recognizing events with known value '{exc_value}'" ) } }