From 8af05644f9482d6cea2e1760e4ab9b36790d849d Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Tue, 13 Jun 2023 08:51:06 -0700 Subject: [PATCH 1/3] add "dead object" filter --- relay-filter/src/browser_extensions.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/relay-filter/src/browser_extensions.rs b/relay-filter/src/browser_extensions.rs index cb2639b8ba..8a1ad49840 100644 --- a/relay-filter/src/browser_extensions.rs +++ b/relay-filter/src/browser_extensions.rs @@ -40,7 +40,10 @@ static EXTENSION_EXC_VALUES: Lazy = Lazy::new(|| { plugin\.setSuspendState\sis\snot\sa\sfunction| # Chrome extension message passing failure Extension\scontext\sinvalidated| - webkit-masked-url: + webkit-masked-url:| + # Firefox message when an extension tries to modify a no-longer-existing DOM node + # See https://blog.mozilla.org/addons/2012/09/12/what-does-cant-access-dead-object-mean/ + can't\saccess\sdead\sobject "#, ) .expect("Invalid browser extensions filter (Exec Vals) Regex") @@ -252,6 +255,7 @@ mod tests { "plugin.setSuspendState is not a function", "Extension context invalidated", "useless error webkit-masked-url: please filter", + "TypeError: can't access dead object because dead stuff smells bad", ]; for exc_value in &exceptions { From b26225eddd5794fab111c5b0b218b5a4c098b689 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Tue, 13 Jun 2023 08:51:16 -0700 Subject: [PATCH 2/3] add changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 33b0258ee0..5956ecb368 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ - Add `lock` attribute to the frame protocol. ([#2171](https://github.com/getsentry/relay/pull/2171)) - Reject profiles longer than 30s. ([#2168](https://github.com/getsentry/relay/pull/2168)) - Change default topic for transaction metrics to `ingest-performance-metrics`. ([#2180](https://github.com/getsentry/relay/pull/2180)) +- Add Firefox "dead object" error to browser extension filter ([#2215](https://github.com/getsentry/relay/pull/2215)) **Internal**: From 0b23714e963d5c14275418198d352e114c643987 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Tue, 13 Jun 2023 09:04:44 -0700 Subject: [PATCH 3/3] make error message clearer --- relay-filter/src/browser_extensions.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/relay-filter/src/browser_extensions.rs b/relay-filter/src/browser_extensions.rs index 8a1ad49840..e49df3718f 100644 --- a/relay-filter/src/browser_extensions.rs +++ b/relay-filter/src/browser_extensions.rs @@ -264,7 +264,7 @@ mod tests { assert_ne!( filter_result, Ok(()), - "Event filter not recognizing events with known values {exc_value}" + "Event filter not recognizing events with known value '{exc_value}'" ) } }