From 68788e00d898205c3b1affd969eb0749e836dbcc Mon Sep 17 00:00:00 2001 From: David Herberth Date: Thu, 9 Jan 2025 15:35:04 +0100 Subject: [PATCH] ref(normalization): Increase stacktrace function and symbol length limits to 512 chars --- CHANGELOG.md | 1 + relay-event-schema/src/protocol/stacktrace.rs | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c9d3e8d56c5..23fbeedf10e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ **Features**: +- Increase stacktrace function and symbol length limits to 512 chars. ([#4436](https://github.com/getsentry/relay/pull/4436)) - Scrub non-minidump attachments if there are explicit `$attachment` rules. ([#4415](https://github.com/getsentry/relay/pull/4415)) **Internal**: diff --git a/relay-event-schema/src/protocol/stacktrace.rs b/relay-event-schema/src/protocol/stacktrace.rs index 108055a9d09..a48307aa0af 100644 --- a/relay-event-schema/src/protocol/stacktrace.rs +++ b/relay-event-schema/src/protocol/stacktrace.rs @@ -22,7 +22,7 @@ pub struct Frame { /// /// This function name may be shortened or demangled. If not, Sentry will demangle and shorten /// it for some platforms. The original function name will be stored in `raw_function`. - #[metastructure(max_chars = 256, max_chars_allowance = 20)] + #[metastructure(max_chars = 512, max_chars_allowance = 20)] #[metastructure(skip_serialization = "empty")] pub function: Annotated, @@ -39,9 +39,9 @@ pub struct Frame { /// /// The logic to be applied is that an intelligently trimmed function name should be stored in /// `function` and the value before trimming is stored in this field instead. However also this - /// field will be capped at 256 characters at the moment which often means that not the entire + /// field will be capped at 512 characters at the moment which often means that not the entire /// original value can be stored. - #[metastructure(max_chars = 256, max_chars_allowance = 20)] + #[metastructure(max_chars = 512, max_chars_allowance = 20)] #[metastructure(skip_serialization = "empty")] pub raw_function: Annotated, @@ -52,7 +52,7 @@ pub struct Frame { /// like Swift, C++ or Rust. // XXX(markus): How is this different from just storing the mangled function name in // `function`? - #[metastructure(max_chars = 256)] + #[metastructure(max_chars = 512)] pub symbol: Annotated, /// Name of the module the frame is contained in.