From 512ef36a8ae3d13136b57fecabfb01f4177ad546 Mon Sep 17 00:00:00 2001 From: Philipp Hofmann Date: Tue, 8 Nov 2022 15:47:33 +0100 Subject: [PATCH] Revert "feat: Track usage of the enableCaptureFailedRequests option (#2368)" (#2371) This reverts commit a6899a2eedf80ea2bef30989de1ec840d0a5566d. --- CHANGELOG.md | 4 ---- Sources/Sentry/Public/SentryOptions.h | 2 +- Sources/Sentry/SentryClient.m | 4 ---- Tests/SentryTests/SentryClientTests.swift | 16 ---------------- 4 files changed, 1 insertion(+), 25 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d9d0f986f3c..44bff4d10aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,10 +2,6 @@ ## Unreleased -### Features - -- Report usage of enableCaptureFailedRequests (#2368) - ### Fixes - Fix issue with invalid profiles uploading (#2358 and #2359) diff --git a/Sources/Sentry/Public/SentryOptions.h b/Sources/Sentry/Public/SentryOptions.h index b33eae0e5d7..efa1537d230 100644 --- a/Sources/Sentry/Public/SentryOptions.h +++ b/Sources/Sentry/Public/SentryOptions.h @@ -416,7 +416,7 @@ NS_SWIFT_NAME(Options) /** * When enabled, the SDK captures HTTP Client errors. Default value is NO. - * This feature requires enableSwizzling enabled as well, default value is YES. + * This feature requires enableSwizzling enabled as well, Default value is YES. */ @property (nonatomic, assign) BOOL enableCaptureFailedRequests; diff --git a/Sources/Sentry/SentryClient.m b/Sources/Sentry/SentryClient.m index 6165f843403..3f916aa5ba7 100644 --- a/Sources/Sentry/SentryClient.m +++ b/Sources/Sentry/SentryClient.m @@ -654,10 +654,6 @@ - (void)setSdk:(SentryEvent *)event if (self.options.stitchAsyncCode) { [integrations addObject:@"StitchAsyncCode"]; } - - if (self.options.enableCaptureFailedRequests) { - [integrations addObject:@"CaptureFailedRequests"]; - } } event.sdk = @{ diff --git a/Tests/SentryTests/SentryClientTests.swift b/Tests/SentryTests/SentryClientTests.swift index 181ff8d14b5..c3e0f5359f2 100644 --- a/Tests/SentryTests/SentryClientTests.swift +++ b/Tests/SentryTests/SentryClientTests.swift @@ -1047,22 +1047,6 @@ class SentryClientTest: XCTestCase { ) } } - - func testTrackEnableCaptureFailedRequests() { - SentrySDK.start(options: Options()) - - let eventId = fixture.getSut(configureOptions: { options in - options.enableCaptureFailedRequests = true - }).capture(message: fixture.messageAsString) - - eventId.assertIsNotEmpty() - assertLastSentEvent { actual in - assertArrayEquals( - expected: ["AutoBreadcrumbTracking", "AutoSessionTracking", "Crash", "NetworkTracking", "CaptureFailedRequests"], - actual: actual.sdk?["integrations"] as? [String] - ) - } - } func testSetSDKIntegrations_NoIntegrations() { let expected: [String] = []