From 59161ef19a24c196649937c542cd9a70d4b8eb97 Mon Sep 17 00:00:00 2001 From: BJ Homer <276263+bjhomer@users.noreply.github.com> Date: Fri, 14 Jul 2023 14:49:20 -0600 Subject: [PATCH] Avoid crashing in SentryCoreDataTracker Users can pass in a `nil` error parameter when calling Core Data methods like `save:` and `executeFetchRequest:`. We were incorrectly handling that nil error parameter and trying to dereference it inside SENTRY_LOG_DEBUG calls. This commit fixes that. --- Sources/Sentry/SentryCoreDataTracker.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Sources/Sentry/SentryCoreDataTracker.m b/Sources/Sentry/SentryCoreDataTracker.m index 80568078dfb..df75fd8c8c1 100644 --- a/Sources/Sentry/SentryCoreDataTracker.m +++ b/Sources/Sentry/SentryCoreDataTracker.m @@ -67,7 +67,7 @@ - (NSArray *)managedObjectContext:(NSManagedObjectContext *)context finishWithStatus:result == nil ? kSentrySpanStatusInternalError : kSentrySpanStatusOk]; SENTRY_LOG_DEBUG(@"SentryCoreDataTracker automatically finished span with status: %@", - error == nil ? @"ok" : @"error"); + result == nil ? @"error" : @"ok"); } return result; @@ -109,7 +109,7 @@ - (BOOL)managedObjectContext:(NSManagedObjectContext *)context [fetchSpan finishWithStatus:result ? kSentrySpanStatusOk : kSentrySpanStatusInternalError]; SENTRY_LOG_DEBUG(@"SentryCoreDataTracker automatically finished span with status: %@", - *error == nil ? @"ok" : @"error"); + result ? @"ok" : @"error"); } return result;