fix: Remove extra unregister (#5601)

noahsmartin · web-flow · commit c585b1e5b06f · 2025-07-10T13:15:26.000-04:00
diff --git a/Sources/Sentry/SentrySystemEventBreadcrumbs.m b/Sources/Sentry/SentrySystemEventBreadcrumbs.m
@@ -56,9 +56,6 @@ - (void)stop
     [self.notificationCenterWrapper removeObserver:self
                                               name:UIDeviceOrientationDidChangeNotification
                                             object:nil];
-    [self.notificationCenterWrapper removeObserver:self
-                                              name:UIDeviceOrientationDidChangeNotification
-                                            object:nil];
 }
 
 - (void)dealloc
diff --git a/Tests/SentryTests/Integrations/Breadcrumbs/SentrySystemEventBreadcrumbsTest.swift b/Tests/SentryTests/Integrations/Breadcrumbs/SentrySystemEventBreadcrumbsTest.swift
@@ -327,7 +327,7 @@ class SentrySystemEventBreadcrumbsTest: XCTestCase {
     func testStopCallsSpecificRemoveObserverMethods() {
         sut = fixture.getSut(currentDevice: nil)
         sut.stop()
-        XCTAssertEqual(fixture.notificationCenterWrapper.removeObserverWithNameAndObjectInvocations.count, 7)
+        XCTAssertEqual(fixture.notificationCenterWrapper.removeObserverWithNameAndObjectInvocations.count, 6)
     }
     
     private func postBatteryLevelNotification(uiDevice: UIDevice?) {

Original file line number	Diff line number	Diff line change
`@@ -56,9 +56,6 @@ - (void)stop`
`56`	`56`	`[self.notificationCenterWrapper removeObserver:self`
`57`	`57`	`name:UIDeviceOrientationDidChangeNotification`
`58`	`58`	`object:nil];`
`59`		`- [self.notificationCenterWrapper removeObserver:self`
`60`		`- name:UIDeviceOrientationDidChangeNotification`
`61`		`- object:nil];`
`62`	`59`	`}`
`63`	`60`
`64`	`61`	`- (void)dealloc`
Original file line number	Diff line number	Diff line change
`@@ -327,7 +327,7 @@ class SentrySystemEventBreadcrumbsTest: XCTestCase {`
`327`	`327`	`func testStopCallsSpecificRemoveObserverMethods() {`
`328`	`328`	`sut = fixture.getSut(currentDevice: nil)`
`329`	`329`	`sut.stop()`
`330`		`- XCTAssertEqual(fixture.notificationCenterWrapper.removeObserverWithNameAndObjectInvocations.count, 7)`
	`330`	`+ XCTAssertEqual(fixture.notificationCenterWrapper.removeObserverWithNameAndObjectInvocations.count, 6)`
`331`	`331`	`}`
`332`	`332`
`333`	`333`	`private func postBatteryLevelNotification(uiDevice: UIDevice?) {`