From 02e696ea4548c1608bfd82263534aa6c4d3362f8 Mon Sep 17 00:00:00 2001 From: Denis Andrasec Date: Mon, 22 May 2023 10:41:13 +0200 Subject: [PATCH 1/2] Update native sdk names --- .../src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt | 2 +- flutter/ios/Classes/SentryFlutterPluginApple.swift | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt b/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt index 00819cc1ed..c074aa8d6f 100644 --- a/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt +++ b/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt @@ -41,7 +41,7 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware { private var autoPerformanceTracingEnabled = false private val flutterSdk = "sentry.dart.flutter" - private val androidSdk = "sentry.java.android.flutter" + private val androidSdk = "sentry.native.android.flutter" private val nativeSdk = "sentry.native.android" override fun onAttachedToEngine(flutterPluginBinding: FlutterPlugin.FlutterPluginBinding) { diff --git a/flutter/ios/Classes/SentryFlutterPluginApple.swift b/flutter/ios/Classes/SentryFlutterPluginApple.swift index d5baa5fd0f..7f6cfb26c8 100644 --- a/flutter/ios/Classes/SentryFlutterPluginApple.swift +++ b/flutter/ios/Classes/SentryFlutterPluginApple.swift @@ -12,7 +12,7 @@ import AppKit // swiftlint:disable:next type_body_length public class SentryFlutterPluginApple: NSObject, FlutterPlugin { - private static let nativeClientName = "sentry.cocoa.flutter" + private static let nativeClientName = "sentry.native.cocoa.flutter" // The Cocoa SDK is init. after the notification didBecomeActiveNotification is registered. // We need to be able to receive this notification and start a session when the SDK is fully operational. From 216d1f3d0c0a2356efb0aac2b291d2ad95eebe16 Mon Sep 17 00:00:00 2001 From: Manoel Aranda Neto Date: Tue, 23 May 2023 14:06:56 +0200 Subject: [PATCH 2/2] fix name --- .../src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt | 5 +++-- flutter/ios/Classes/SentryFlutterPluginApple.swift | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt b/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt index c074aa8d6f..492638dffc 100644 --- a/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt +++ b/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt @@ -41,8 +41,8 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware { private var autoPerformanceTracingEnabled = false private val flutterSdk = "sentry.dart.flutter" - private val androidSdk = "sentry.native.android.flutter" - private val nativeSdk = "sentry.native.android" + private val androidSdk = "sentry.java.android.flutter" + private val nativeSdk = "sentry.native.android.flutter" override fun onAttachedToEngine(flutterPluginBinding: FlutterPlugin.FlutterPluginBinding) { context = flutterPluginBinding.applicationContext @@ -182,6 +182,7 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware { options.sdkVersion = sdkVersion options.sentryClientName = "$androidSdk/$VERSION_NAME" + options.nativeSdkName = nativeSdk options.setBeforeSend { event, _ -> setEventOriginTag(event) diff --git a/flutter/ios/Classes/SentryFlutterPluginApple.swift b/flutter/ios/Classes/SentryFlutterPluginApple.swift index 7f6cfb26c8..d5baa5fd0f 100644 --- a/flutter/ios/Classes/SentryFlutterPluginApple.swift +++ b/flutter/ios/Classes/SentryFlutterPluginApple.swift @@ -12,7 +12,7 @@ import AppKit // swiftlint:disable:next type_body_length public class SentryFlutterPluginApple: NSObject, FlutterPlugin { - private static let nativeClientName = "sentry.native.cocoa.flutter" + private static let nativeClientName = "sentry.cocoa.flutter" // The Cocoa SDK is init. after the notification didBecomeActiveNotification is registered. // We need to be able to receive this notification and start a session when the SDK is fully operational.