-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test for iOS/Android #1516
Merged
Merged
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f2bdc3f
add integration test app and run e2e test
denrase 58b1c89
poll and validate event in test, not in app
denrase ea2826f
Merge branch 'main' into enha/ui-integration-tests
denrase a89db45
name the different dsn vars
denrase b90e862
do test in example app
denrase 30fde7b
remove it app
denrase 896fae5
Merge branch 'main' into enha/ui-integration-tests
denrase da32364
Merge branch 'main' into enha/ui-integration-tests
denrase c3264dc
Merge branch 'main' into enha/ui-integration-tests
denrase 0342b49
test same properties as kmm
denrase 984c0a5
Merge branch 'main' into enha/ui-integration-tests
marandaneto 703e3fa
Merge branch 'main' into enha/ui-integration-tests
marandaneto d143570
remove redundant permissions
denrase 6c53f13
Merge branch 'main' into enha/ui-integration-tests
denrase b576967
Merge branch 'main' into enha/ui-integration-tests
denrase 6276ead
Merge branch 'main' into enha/ui-integration-tests
marandaneto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we actually validate more properties in the event?
I know this is a copy of https://github.com/getsentry/sentry-dart/blob/main/e2e_test/bin/e2e_test.dart
Maybe we should improve that test as well.
The goal is that we assert every property that is static and not dependent on the host platform, so it wont fail in different devices, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I check fro the same properties than getsentry/sentry-kotlin-multiplatform#78 now. Do we need more? If not, i will update the dart only test as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start with the current approach and expand as we go.
Ideally, we'd check every property that is static, does not change depending on the device, etc.