Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Flutter dep from Drift integration #1867

Merged
merged 6 commits into from
Feb 7, 2024
Merged

fix: remove Flutter dep from Drift integration #1867

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ddc26d8
Remove Flutter dep
buenaflor Feb 6, 2024
6fa100c
Update CHANGELOG
buenaflor Feb 6, 2024
d55e583
Merge branch 'main' into fix/remove-drift-flutter-dep
buenaflor Feb 6, 2024
fd1be7a
Merge branch 'main' into fix/remove-drift-flutter-dep
buenaflor Feb 7, 2024
3c61e86
trigger test workflow
buenaflor Feb 7, 2024
0595ef4
update
buenaflor Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@

## Unreleased

### Fixes
### Fixes
buenaflor marked this conversation as resolved.
Show resolved Hide resolved

- Remove Flutter dependency from Drift integration ([#1867](https://github.com/getsentry/sentry-dart/pull/1867))
- Remove dead code, cold start bool is now always present ([#1861](https://github.com/getsentry/sentry-dart/pull/1861))

### Dependencies
Expand Down
2 changes: 1 addition & 1 deletion drift/example/example.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Future<void> runApp() async {

await db.into(db.todoItems).insert(
TodoItemsCompanion.insert(
title: 'This is a test thing',
title: 'This is a test item',
content: 'test',
),
);
Expand Down
1 change: 0 additions & 1 deletion drift/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ issue_tracker: https://github.com/getsentry/sentry-dart/issues

environment:
sdk: '>=2.17.0 <4.0.0'
flutter: '>=3.3.0'

dependencies:
sentry: 7.16.0
Expand Down
Loading