Unhandled -> UnhandledTerminal

Author: bitsandfoxes

src/Sentry/Internal/Hub.cs

@@ -585,7 +585,7 @@ private SentryId CaptureEvent(SentryEvent evt, SentryHint? hint, Scope scope)
             scope.LastEventId = id;
             scope.SessionUpdate = null;
 
-            if (evt.GetExceptionType() is SentryEvent.ExceptionType.Unhandled
+            if (evt.GetExceptionType() is SentryEvent.ExceptionType.UnhandledTerminal
                 && scope.Transaction is { } transaction)
             {
                 // Event contains a terminal exception -> finish any current transaction as aborted

src/Sentry/Platforms/Android/LogCatAttachmentEventProcessor.cs

@@ -55,7 +55,7 @@ public SentryEvent Process(SentryEvent @event, SentryHint hint)
             // Only send logcat logs if the event is unhandled if the integration is set to Unhandled
             if (_logCatIntegrationType == LogCatIntegrationType.Unhandled)
             {
-                if (exceptionType != SentryEvent.ExceptionType.Unhandled && exceptionType != SentryEvent.ExceptionType.UnhandledNonTerminal)
+                if (exceptionType != SentryEvent.ExceptionType.UnhandledTerminal && exceptionType != SentryEvent.ExceptionType.UnhandledNonTerminal)
                 {
                     return @event;
                 }

src/Sentry/SentryClient.cs

@@ -355,7 +355,7 @@ private SentryId DoSendEvent(SentryEvent @event, SentryHint? hint, Scope? scope)
                 scope.SessionUpdate = _sessionManager.EndSession(SessionEndStatus.Unhandled);
                 break;
 
-            case SentryEvent.ExceptionType.Unhandled:
+            case SentryEvent.ExceptionType.UnhandledTerminal:
                 _options.LogDebug("Ending session as 'Crashed', due to unhandled exception.");
                 scope.SessionUpdate = _sessionManager.EndSession(SessionEndStatus.Crashed);
                 break;

src/Sentry/SentryEvent.cs

@@ -182,7 +182,7 @@ internal enum ExceptionType
     {
         None,
         Handled,
-        Unhandled,
+        UnhandledTerminal,
         UnhandledNonTerminal
     }
 
@@ -200,7 +200,7 @@ internal ExceptionType GetExceptionType()
 
         if (HasUnhandledException())
         {
-            return ExceptionType.Unhandled;
+            return ExceptionType.UnhandledTerminal;
         }
 
         return ExceptionType.Handled;

test/Sentry.Tests/Protocol/SentryEventTests.cs

@@ -204,7 +204,7 @@ public void GetExceptionType_UnhandledTerminalException_ReturnsUnhandled()
         exception.SetSentryMechanism("AppDomain.UnhandledException", handled: false, terminal: true);
         var evt = new SentryEvent(exception);
 
-        Assert.Equal(SentryEvent.ExceptionType.Unhandled, evt.GetExceptionType());
+        Assert.Equal(SentryEvent.ExceptionType.UnhandledTerminal, evt.GetExceptionType());
     }
 
     [Fact]
@@ -215,7 +215,7 @@ public void GetExceptionType_UnhandledTerminalExceptionViaSentryExceptions_Retur
             SentryExceptions = [new SentryException { Mechanism = new Mechanism { Handled = false } }]
         };
 
-        Assert.Equal(SentryEvent.ExceptionType.Unhandled, evt.GetExceptionType());
+        Assert.Equal(SentryEvent.ExceptionType.UnhandledTerminal, evt.GetExceptionType());
     }
 
     [Fact]