Concurrent HTTP client requests show as parent/child relationship instead of sibling

[jason-kingsmill]

Package

Sentry.AspNetCore

.NET Flavor

.NET Core

.NET Version

8

OS

Any (not platform specific)

OS Version

No response

Development Environment

Visual Studio v17.x

SDK Version

5.16

Self-Hosted Sentry Version

No response

Workload Versions

N/A

UseSentry or SentrySdk.Init call

builder.WebHost.UseSentry(opt =>
{
opt.ApplySerilogScopeToEvents();
opt.MinimumBreadcrumbLevel = Microsoft.Extensions.Logging.LogLevel.Information;
opt.MinimumEventLevel = Microsoft.Extensions.Logging.LogLevel.Error;
opt.DisableDiagnosticSourceIntegration();
opt.Experimental.EnableLogs = true;
opt.UseOpenTelemetry();

// We want to force the sample rate, ignoring any "sampled" headers coming from the API
var configuredRate = builder.Configuration.GetValue<double?>("Sentry:TracesSampleRate") ?? 1.0;
opt.TracesSampler = _ => configuredRate;    

});

Steps to Reproduce

1. From and starting transaction, make multiple concurrent outbound HttpClient requests

Expected Result

Sentry should show the spans from each request as siblings

Actual Result

Sentry shows all http.client spans as parent/child relationship starting from the first to the last

Note:
We use OpenTelemetry simply so we can gather MassTransit telemetry, which requires disabling Diagnostic Source Integration.
I'm not sure if this is potentially a cause of the issue?

[linear]

NET-505

[jamescrosswell]

@jason-kingsmill I've never seen this before. Is there any chance you could provide a small reproducible example of the issue (e.g. in a GitHub repo)?

[jason-kingsmill]

@jason-kingsmill I've never seen this before. Is there any chance you could provide a small reproducible example of the issue (e.g. in a GitHub repo)?

Hey @jamescrosswell sorry for the delay.
Here is a reproducible example repo:
https://github.com/jason-kingsmill/SentryTestApp

[jamescrosswell]

Thanks @jason-kingsmill, that helps.

If you're using Open Telemetry, best to stick with it for all of the instrumentation... so use OTEL for the outbound http requests as well. You can do that by adding the OTEL extensions for HTTP:
https://www.nuget.org/packages/OpenTelemetry.Instrumentation.Http

Then in your code, enable these and disable the Sentry instrumentation for the same:

builder.Services.AddOpenTelemetry()
    .WithTracing(tracerProviderBuilder =>
        tracerProviderBuilder
            .AddAspNetCoreInstrumentation()
+           .AddHttpClientInstrumentation()

...

builder.WebHost.UseSentry(opt =>  
{
    // opt.Dsn = "<insert dsn here>";
    opt.MinimumBreadcrumbLevel = Microsoft.Extensions.Logging.LogLevel.Information;
    opt.MinimumEventLevel = Microsoft.Extensions.Logging.LogLevel.Error;
    opt.DisableDiagnosticSourceIntegration();
+   opt.DisableSentryHttpMessageHandler = true;

When I do that, the waterfall looks better for me:

We should probably add this to the docs, since this isn't obvious.