Skip to content

Conversation

@alexsohn1126
Copy link
Member

Fixes #3337

Problem

We were overwriting Event's user IP address in ASP.NET if it was set manually.

Solution

We only populate an event's user ip if it was not set before.

@alexsohn1126 alexsohn1126 changed the title fix: do not overwrite user ip if set manually fix: Do not overwrite user ip if set manually Sep 11, 2025
cursor[bot]

This comment was marked as outdated.

@alexsohn1126 alexsohn1126 changed the title fix: Do not overwrite user ip if set manually fix: Do not overwrite user ip if set manually in ASP.NET sdk Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.43%. Comparing base (4a2bf5f) to head (a482e19).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
....AspNet/Internal/SystemWebRequestEventProcessor.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4513      +/-   ##
==========================================
+ Coverage   73.38%   73.43%   +0.05%     
==========================================
  Files         479      479              
  Lines       17506    17506              
  Branches     3479     3480       +1     
==========================================
+ Hits        12846    12856      +10     
+ Misses       3780     3772       -8     
+ Partials      880      878       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexsohn1126
Copy link
Member Author

bugbot review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks @alexsohn1126 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sentry SDK is overwriting the User.IpAddress on ASP.NET

3 participants