-
-
Notifications
You must be signed in to change notification settings - Fork 226
fix: Do not overwrite user ip if set manually in ASP.NET sdk #4513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Do not overwrite user ip if set manually in ASP.NET sdk #4513
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4513 +/- ##
==========================================
+ Coverage 73.38% 73.43% +0.05%
==========================================
Files 479 479
Lines 17506 17506
Branches 3479 3480 +1
==========================================
+ Hits 12846 12856 +10
+ Misses 3780 3772 -8
+ Partials 880 878 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
bugbot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
jamescrosswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - thanks @alexsohn1126 !
Fixes #3337
Problem
We were overwriting Event's user IP address in ASP.NET if it was set manually.
Solution
We only populate an event's user ip if it was not set before.