Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap HTTP requests in try/catch #515

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Wrap HTTP requests in try/catch #515

merged 2 commits into from
Jul 12, 2023

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Jul 27, 2022

closes #514

@ruslandoga ruslandoga marked this pull request as ready for review July 27, 2022 15:09
@ruslandoga ruslandoga marked this pull request as draft July 27, 2022 15:09
@ruslandoga ruslandoga marked this pull request as ready for review July 27, 2022 15:24
lib/sentry/client.ex Outdated Show resolved Hide resolved
@ruslandoga ruslandoga marked this pull request as draft July 31, 2022 14:01
lib/sentry/client.ex Outdated Show resolved Hide resolved
lib/sentry/client.ex Outdated Show resolved Hide resolved
lib/sentry/client.ex Outdated Show resolved Hide resolved
lib/sentry/client.ex Outdated Show resolved Hide resolved
lib/sentry/client.ex Outdated Show resolved Hide resolved
lib/sentry/client.ex Outdated Show resolved Hide resolved
@ruslandoga ruslandoga marked this pull request as ready for review August 1, 2022 10:17
@ruslandoga ruslandoga closed this Sep 12, 2022
@ruslandoga ruslandoga reopened this Sep 12, 2022
@ukutaht
Copy link

ukutaht commented Nov 8, 2022

Hey @mitchellhenke. Sorry to bother you but we'd like to move this along if you have some time to look at it. The issue with infinite error loops #514 is forcing us to run a fork of this library in prod for https://plausible.io

We know from first-hand experience how difficult it is to maintain OS libraries on the side. We're committed to open source work and want to help out the whole ecosystem with the resources that we have. @ruslandoga has recently started working with us as a dedicated Open Source developer to help improve the ecosystem we depend on. The work we do in OSS is with dedicated funding from 5% donation budget which we launched last year.

I'm not sure how this project is run or managed. If you need help, we'd be happy to be discuss onboarding @ruslandoga as a maintainer to lighten your load going forward. Not trying to be pushy, just offering some free help. Thanks for all of your work on this so far ❤️

@sl0thentr0py
Copy link
Member

@ruslandoga I'm breathing new life into this repo, would you still like to see this merged?
can you merge latest master and push again if so?

@ruslandoga
Copy link
Contributor Author

@sl0thentr0py Sure!

@ruslandoga
Copy link
Contributor Author

ruslandoga commented Feb 2, 2023

Done.

I'll go over this PR tomorrow in the next few exactly 131 days from now to check if I still think this is the correct solution. I'll mark it as a draft for now.

@ruslandoga ruslandoga marked this pull request as draft February 2, 2023 14:06
@ruslandoga ruslandoga marked this pull request as ready for review June 13, 2023 05:08
@ruslandoga
Copy link
Contributor Author

👋 @sl0thentr0py

Sorry for taking so long to get back to it.

I've cleaned up the PR to only fix the original issue. It should make it easier to review. I'll open another PR for direct logging from the client once this one is merged.

test/client_test.exs Outdated Show resolved Hide resolved
@ruslandoga ruslandoga requested a review from whatyouhide July 12, 2023 11:28
test/test_helper.exs Outdated Show resolved Hide resolved
@whatyouhide whatyouhide changed the title try/catch requests in http client Wrap HTTP requests in try/catch Jul 12, 2023
Copy link
Collaborator

@whatyouhide whatyouhide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👏

@whatyouhide whatyouhide merged commit ab02160 into getsentry:master Jul 12, 2023
@ruslandoga ruslandoga deleted the try-catch-http branch July 12, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibly infinite error loop with custom http client.
5 participants