Fix on_mount LiveView hook when given :not_mounted_at_router
#742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
reviewed
Jun 27, 2024
test/sentry/live_view_hook_test.exs
Outdated
Comment on lines
46
to
48
| defmodule SentryTest.ErrorView do | ||
| def render(template, _), do: Phoenix.Controller.status_message_from_template(template) | ||
| end |
There was a problem hiding this comment.
Do you need this considering you're just returning some text with text/2?
whatyouhide
changed the title
whatyouhide
changed the title
on_mount LiveView hook when given :not_mounted_at_router
added 2 commits
June 27, 2024 09:38
savhappy
force-pushed
the
sav/#738-liveviewhook
branch
from
e53d982 to
bce503b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #738.