Add integration_meta key to event #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
requested changes
Aug 17, 2024
lib/sentry/event.ex
Outdated
Comment on lines
260
to
266
| integration_meta: [ | ||
| type: :map, | ||
| doc: """ | ||
| A map to store metadata specific to the integration. | ||
| It allows cron integrations, such as the Oban integration, | ||
| to store job-related metadata. *Available since v10.1.0*. | ||
| """ |
There was a problem hiding this comment.
For now this can be doc: false instead since integrations are all internal to the Sentry SDK.
lib/sentry/event.ex
Outdated
Comment on lines
352
to
353
| event = | ||
| %__MODULE__{ |
There was a problem hiding this comment.
Can you not change the formatting of this? Makes it harder to review 🙃
There was a problem hiding this comment.
Ah yes! My linter did this..
| @@ -41,7 +41,9 @@ defmodule Sentry.Integrations.Oban.ErrorReporter do | |||
| inspect(job.worker), | |||
| Exception.message(exception) | |||
| ], | |||
| extra: Map.take(job, [:args, :attempt, :id, :max_attempts, :meta, :queue, :tags, :worker]) | |||
| extra: | |||
| Map.take(job, [:args, :attempt, :id, :max_attempts, :meta, :queue, :tags, :worker]), | |||
There was a problem hiding this comment.
We need tests for this 🧪
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
whatyouhide
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added an integration_meta key to store the metadata of a cron job, allowing the user to filter what events are reported based on the values.
-Alternate solution to PR #759
-Related to #757