diff --git a/CHANGELOG.md b/CHANGELOG.md index 9f994a8bcc..d032e8cd95 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ * Fix: Make the ANR Atomic flags immutable * Enchancement: Integration interface better compatibility with Kotlin null-safety * Enchancement: Simplify Sentry configuration in Spring integration (#1259) +* Enchancement: Simplify configuring Logback integration when environment variable with the DSN is not set (#1271) * Fix: Prevent NoOpHub from creating heavy SentryOptions objects (#1272) * Enchancement: Add Request to the Scope. #1270 * Fix: Fix SentryTransaction#getStatus NPE (#1273) diff --git a/sentry-logback/src/main/java/io/sentry/logback/SentryAppender.java b/sentry-logback/src/main/java/io/sentry/logback/SentryAppender.java index b2cfc53ad3..2716b7c266 100644 --- a/sentry-logback/src/main/java/io/sentry/logback/SentryAppender.java +++ b/sentry-logback/src/main/java/io/sentry/logback/SentryAppender.java @@ -35,14 +35,20 @@ public final class SentryAppender extends UnsynchronizedAppenderBase() @@ -40,7 +41,7 @@ class SentryAppenderTest { whenever(this.transportFactory.create(any(), any())).thenReturn(transport) val appender = SentryAppender() val options = SentryOptions() - options.dsn = "http://key@localhost/proj" + options.dsn = dsn appender.setOptions(options) appender.setMinimumBreadcrumbLevel(minimumBreadcrumbLevel) appender.setMinimumEventLevel(minimumEventLevel) @@ -305,4 +306,12 @@ class SentryAppenderTest { }, anyOrNull()) } } + + @Test + fun `does not initialize Sentry when environment variable with DSN is not set`() { + // environment variables referenced in the logback.xml that are not set in the OS, have value "ENV_NAME_IS_UNDEFINED" + fixture = Fixture(dsn = "DSN_IS_UNDEFINED", minimumEventLevel = Level.DEBUG) + + assertTrue(fixture.loggerContext.statusManager.copyOfStatusList.none { it.level == Status.WARN }) + } } diff --git a/sentry-samples/sentry-samples-logback/src/main/resources/logback.xml b/sentry-samples/sentry-samples-logback/src/main/resources/logback.xml index ebfa585671..9c97514312 100644 --- a/sentry-samples/sentry-samples-logback/src/main/resources/logback.xml +++ b/sentry-samples/sentry-samples-logback/src/main/resources/logback.xml @@ -8,6 +8,7 @@ + true https://502f25099c204a2fbf4cb16edc5975d1@o447951.ingest.sentry.io/5428563