Replace SpanClass with isSpan helper

Author: andreiborza

packages/opentelemetry/test/helpers/isSpan.ts

@@ -0,0 +1,12 @@
+import type { Span } from '@opentelemetry/api';
+import { INVALID_TRACEID, INVALID_SPANID, type SpanContext } from '@opentelemetry/api';
+
+export const isSpan = (value: unknown): value is Span => {
+  return (
+    typeof value === 'object' &&
+    value !== null &&
+    'spanContext' in value &&
+    (value.spanContext as () => SpanContext)().traceId !== INVALID_TRACEID &&
+    (value.spanContext as () => SpanContext)().spanId !== INVALID_SPANID
+  );
+};

packages/opentelemetry/test/trace.test.ts

@@ -4,7 +4,6 @@ import { ROOT_CONTEXT } from '@opentelemetry/api';
 import { SpanKind } from '@opentelemetry/api';
 import { TraceFlags, context, trace } from '@opentelemetry/api';
 import type { ReadableSpan } from '@opentelemetry/sdk-trace-base';
-import { Span as SpanClass } from '@opentelemetry/sdk-trace-base';
 import {
   SEMANTIC_ATTRIBUTE_SENTRY_OP,
   SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
@@ -32,6 +31,8 @@ import { getSpanKind } from '../src/utils/getSpanKind';
 import { makeTraceState } from '../src/utils/makeTraceState';
 import { spanHasAttributes, spanHasName } from '../src/utils/spanTypes';
 import { cleanupOtel, mockSdkInit } from './helpers/mockSdkInit';
+import { isSpan } from './helpers/isSpan';
+import { INSPECT_MAX_BYTES } from 'buffer';
 
 describe('trace', () => {
   beforeEach(() => {
@@ -537,7 +538,7 @@ describe('trace', () => {
           return span;
         });
 
-        expect(span).not.toBeInstanceOf(SpanClass);
+        expect(isSpan(span)).toEqual(false);
       });
 
       it('creates a span if there is a parent', () => {
@@ -549,7 +550,7 @@ describe('trace', () => {
           return span;
         });
 
-        expect(span).toBeInstanceOf(SpanClass);
+        expect(isSpan(span)).toEqual(true);
       });
     });
   });
@@ -829,7 +830,7 @@ describe('trace', () => {
       it('does not create a span if there is no parent', () => {
         const span = startInactiveSpan({ name: 'test span', onlyIfParent: true });
 
-        expect(span).not.toBeInstanceOf(SpanClass);
+        expect(isSpan(span)).toEqual(false);
       });
 
       it('creates a span if there is a parent', () => {
@@ -839,7 +840,7 @@ describe('trace', () => {
           return span;
         });
 
-        expect(span).toBeInstanceOf(SpanClass);
+        expect(isSpan(span)).toEqual(true);
       });
     });
 
@@ -1199,7 +1200,7 @@ describe('trace', () => {
           return span;
         });
 
-        expect(span).not.toBeInstanceOf(SpanClass);
+        expect(isSpan(span)).toEqual(false);
       });
 
       it('creates a span if there is a parent', () => {
@@ -1211,7 +1212,7 @@ describe('trace', () => {
           return span;
         });
 
-        expect(span).toBeInstanceOf(SpanClass);
+        expect(isSpan(span)).toEqual(true);
       });
     });
   });