From f3a231182f7a79481a1f2cf41402582d06d14f7c Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Fri, 11 Oct 2024 13:27:54 +0200 Subject: [PATCH] ci: Ensure we check correctly for bot users (#13955) It seems that `github.actor` is not necessarily the PR author, but possibly the user that merged the PR. You can see e.g. here: https://github.com/getsentry/sentry-javascript/actions/runs/11270299315/job/31340702772 how it still ran for a dependabot PR. --- .github/workflows/external-contributors.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/external-contributors.yml b/.github/workflows/external-contributors.yml index 3d5954de8bfa..aac1805c1bb5 100644 --- a/.github/workflows/external-contributors.yml +++ b/.github/workflows/external-contributors.yml @@ -18,7 +18,7 @@ jobs: && github.event.pull_request.author_association != 'COLLABORATOR' && github.event.pull_request.author_association != 'MEMBER' && github.event.pull_request.author_association != 'OWNER' - && endsWith(github.actor, '[bot]') == false + && endsWith(github.event.pull_request.user.login, '[bot]') == false steps: - uses: actions/checkout@v4 - name: Set up Node