Fetch resolves before response has been received; response is undefined

[andreasphil]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/vue

SDK Version

8.22.0

Framework Version

Vue 3.4.35

Link to Sentry event

No response

Reproduction Example/SDK Setup

Unfortunately I don't have a reproduction, but this is our setup:

• Vue SPA with useFetch for handling network requests
• Our repository: @digitalservicebund/ris-norms
• Sentry init: main.ts
• useFetch setup: apiService.ts

(Note that I debugged useFetch and it seems to not be a useFetch issue, see Steps to Reproduce below)

Steps to Reproduce

Summary: for some long-running (a few seconds, but <10s), fetch resolves before the actual request has finished. This leads to the fetch response being undefined. Anything accessing properties of the response then crashes. Reverting to @sentry/vue v8.20.0 fixes the issue.

Example:

fetch("some-long-running-request").then((response) => {
  // Now response is sometimes undefined, so the following would lead to a TypeError:
  if (response.status === 400) {
    // ...
  }
})

Looking at the network dev tools and server logs, I can verify that the request is fulfilled successfully. However it seems that fetch resolves before the request has finished, with undefined as the value for the response.

Possibly related:

• feat(core): Adapt spans for client-side fetch to streaming responses #12723
• rewrite of fetch is not exact  #11466 (open but refers to an older version)

Expected Result

Fetch should not resolve before the request is finished, and response should not be undefined.

Actual Result

Fetch resolves before the request has finished, response is undefined, and accessing properties of the response causes errors.

[chargome]

Hey @andreasphil thanks for reaching out. The PR you mentioned should not affect your original fetch call, as we just try to clone the response and resolve it in parallel.

Does the endpoint you are calling make use of SSE?

Anyway, I'll try to verify your issue and get back to you.

[andreasphil]

@chargome Thanks for the quick reply!

Yes, it might be unrelated. I'm not familiar with the Sentry code base, just did some quick scanning of the changelogs since v8.20 to see if anything catches my attention.

We're not using SSE.

Thanks for looking into it and let me know if you need more information.

[esetnik]

We have been hit by the same issue and are rolling back to 8.20.0. It looks to be related to #12723

[chargome]

@esetnik are you also using the @sentry/vue SDK?

[esetnik]

@esetnik are you also using the @sentry/vue SDK?

No we are using @sentry/react

[chargome]

@andreasphil I couldn't reproduce this issue with a long running browser fetch request from vue (15s) - everything still worked with 8.22. Will try to see if useFetch has any impact. Do you have any details on how the request is handled on the server side?

@esetnik Could you also provide more details on your setup, maybe we can pin down the issue faster this way.

A small reproducible example would be really helpful for fixing this issue.

[andreasphil]

@chargome On the server side we're using a pretty standard Java Spring Boot REST API. This is one of the controllers for the requests that were starting to reliably cause issues after the SDK update.

FWIW all our code is public in the repo I linked (frontend + backend). It's not a small codebase though so I don't expect you to read all of it, but maybe it still helps.

Unfortunately I'm not sure if I will find the time to create a reproducible example but I'll see what I can do next week.

[chargome]

@andreasphil thanks, let's see if we can reproduce it somehow.

[esetnik]

I believe it's related to aborted fetch requests. We use an AbortController to abort the requests and seem to be seeing this only on endpoints where we actually frequently abort fetch requests.

[AbhiPrasad]

@esetnik great suggestion on the aborted request - that seems to be it

opened #13202 to fix this, we'll get a release out on monday after I add (several) e2e tests 😄

[andreasphil]

@esetnik good catch, I was about to say something similar. I did some debugging with our app including the Sentry SDK, here are some findings:

• In our case too the two places in the frontend where we saw the issue make use of AbortControllers. Those happen also to be our longest running requests so I might've gotten confused there (sorry!)
• Specifically, useFetch tends to use AbortControllers frequently because it re-fetches when relevant parameters such as the URL change, aborting pending requests.
• Setting traceFetch to false solves the issue even in @sentry/vue 8.22.0, so perhaps it is caused by something that happens in the instrumentation of outgoing requests or one of the handlers that get attached there
• We specifically treat AbortErrors in our fetch hooks and this is not called anymore because aborted requests error due to the response being undefined
• From what I could see in the debugger, the AbortError does appear in various places where Sentry handles the fetch result, but somehow then fetch is still resolved

This is where I'm going to stop for today but hope that helps. And again, thanks for looking into it!

[AbhiPrasad]

thanks for validating @andreasphil

and to everyone who runs into this, sorry for the trouble, we're on this to fix! Appreciate all the help.

[lforst]

Hi all, we just released version 8.23.0 of the SDK which includes a fix for this bug. Feel free to try it out and let us know if it resolved the issue for you. Thanks!

[andreasphil]

@lforst I can confirm the issue is fixed for us. Thank you!