-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Deprecate hub capture APIs and add them to Scope
#10039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
…rst-put-capture-apis-on-scope
…ry/sentry-javascript into lforst-put-capture-apis-on-scope
lforst
changed the title
feat(core): Put capture APIs on the scope
feat(core): Deprecate hub capture APIs and add them to Jan 5, 2024
Scope
mydea
reviewed
Jan 8, 2024
mydea
reviewed
Jan 8, 2024
mydea
reviewed
Jan 8, 2024
mydea
approved these changes
Jan 8, 2024
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds replacements for the following hub methods on the scope:
hub.captureException
->scope.captureException
hub.captureMessage
->scope.captureMessage
hub.captureEvent
->scope.captureEvent
We are adding all these methods to the scope class and are proxying the calls on the hub through the scope methods. We do not want to change the global calls (
Sentry.capture...()
) to call the scope methods directly yet, because we still require the hub logic forlastEventId
. The scope methods are implicitly now tested because they are called from the hub/top-level methods.Changes: