Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Revert to only use sync debugger for LocalVariables #10077

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jan 5, 2024

This reverts the addition of an async debugger for the LocalVariables integration. Memory leaks were found in the new implimentation.

@timfish timfish requested a review from lforst January 5, 2024 13:27
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Would you mind adding a quick PR description so that we know this is related to memory leakage? Thanks!

@lforst
Copy link
Member

lforst commented Jan 5, 2024

Thank you Tim! <3

@lforst lforst merged commit a443517 into getsentry:develop Jan 5, 2024
55 checks passed
@timfish timfish deleted the fix/node-local-variables branch March 23, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants