-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Deprecate Transaction.getDynamicSamplingContext
in favour of getDynamicSamplingContextFromSpan
#10094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
reviewed
Jan 8, 2024
mydea
reviewed
Jan 8, 2024
mydea
reviewed
Jan 8, 2024
Lms24
force-pushed
the
lms/feat-code-add-getDynamicSamplingFromSpan
branch
from
January 8, 2024 16:52
9f1b607
to
5a5cd5c
Compare
Lms24
force-pushed
the
lms/feat-code-add-getDynamicSamplingFromSpan
branch
from
January 9, 2024 11:27
fd8df14
to
342763c
Compare
mydea
approved these changes
Jan 9, 2024
…ur of `getDynamicSamplingContextFromSpan`
Lms24
force-pushed
the
lms/feat-code-add-getDynamicSamplingFromSpan
branch
from
January 9, 2024 13:24
2319af5
to
5b5dcea
Compare
mydea
approved these changes
Jan 10, 2024
lforst
approved these changes
Jan 10, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates
Transaction.getDynamicSamplingContext
and introduces its direct replacement, a top-level utility function. Note that IMO this only is an intermediate step we should take to rework how we generate and handle the DSC creation. More details in #10095Used various new APIs like
spanToJSON
andspanIsSampled
. Observed that a slight behavioural change is, thatisSpanSampled
always returns a boolean whilespan.sampled
could also be undefined. Considering integration tests still pass, I'd say this is fine.Added new tests for the top level helper and left the older ones in place to still cover
transaction.getDSC
.