Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Deprecate new Transaction() #10125

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 10, 2024

No more transaction class!

This should not really affect users, as they should only use startTransaction() anyhow.

No more transaction class!
@mydea mydea requested review from lforst, Lms24 and AbhiPrasad January 10, 2024 09:22
@mydea mydea self-assigned this Jan 10, 2024
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 76.88 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.25 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 61.88 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.29 KB (+0.16% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.74 KB (+0.04% 🔺)
@sentry/browser - Webpack (gzipped) 22.1 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 74.57 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.2 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.03 KB (+0.12% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.74 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 208.68 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 96.74 KB (+0.07% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 70.95 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35 KB (+0.1% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.63 KB (+0.07% 🔺)
@sentry/react - Webpack (gzipped) 22.13 KB (+0.04% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.36 KB (+0.05% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.48 KB (+0.09% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 16.75 KB (+0.06% 🔺)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@mydea mydea merged commit eb5bb3d into develop Jan 10, 2024
95 checks passed
@mydea mydea deleted the fn/deprecate-transaction branch January 10, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants