fix(sveltekit): add Vite peer dep for proper type resolution #12926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
reviewed
Jul 16, 2024
There was a problem hiding this comment.
Hey @mcous thanks a lot for opening this PR!
I had no idea that pnpm would pick the wrong version. I guess that's another entry in the book of pnpm's weird module resolution behaviours 😅
The change looks fine to me. In our docs, we recommend users to use Vite 4.2 or newer. However, we phrase it in a way that it's not strictly required. So for now I vote we continue with * as a version to fix.
I just started CI. Once everything is green, I'll merge this PR.
(heads-up: Just assigning myself to this PR to track internally that I'm reviewing it)
This was referenced Aug 7, 2024
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Hello! I am in the process of setting up the SvelteKit plugin within a monorepo that includes multiple applications with multiple versions of Vite. I've found that because
@sentry/sveltekitdoes not specify a peer dependency onvite,pnpmpicks up the wrongviteversion for the package'simport type { Plugin } from 'vite'statement, causing type errors in my Vite config.This PR adds a simple, optional peer dependency on Vite to
@sentry/sveltekitto ensure that it picks up whatever version of Vite is being used in the specific package it's installed in, without auto-installingviteor anything disruptive like that. Let me know if you'd prefer specific versions spec'd rather than*, or if you'd prefer to not mark the dependency asoptional: trueNote
I set up Volta as instructed in the Contributing guide and used the spec'd versions of Node and yarn. None of
yarn build,yarn lint, noryarn testfully passed on my machine on a fresh copy of thedevelopbranch