fix(node): Pass inferred name & attributes to tracesSampler
#12945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
size-limit report 📦
|
Lms24
approved these changes
Jul 17, 2024
mydea
commented
Jul 17, 2024
| @@ -45,8 +45,6 @@ export function startSpan<T>(options: OpenTelemetrySpanContext, callback: (span: | |||
| const spanOptions = getSpanOptions(options); | |||
|
|
|||
| return tracer.startActiveSpan(name, spanOptions, ctx, span => { | |||
| _applySentryAttributesToSpan(span, options); | |||
There was a problem hiding this comment.
I noticed that this was actually also not ideal, we just added the op attribute after the span was started, which means this was not sent to the sampler. Also, this is overall unnecessary, we can just add the attribute right away!
This was referenced Aug 9, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we passed the span name directly to the
tracesSampleras-is. However, this is not ideal because this does not match the name we actually send to sentry later, making this confusing. The reason is that we infer the name from the attributes for some types of spans, but we do that at export-time.This PR adjust this so that we send the inferred name & attributes to the
tracesSampler. This works reasonably enough. However, there is a big caveat: This still only has access to the initial attributes that a span has at creation time. This means that we'll never have e.g. thehttp.routecorrectly there, because allhttp.serverspans originate from the http instrumentation where they do not have a route yet, and then more specific instrumentation (e.g. express or fastify) add thehttp.routeto that span later. So the name will never be parametrized, for example, forhttp.serverspans, which is not ideal (as it will still not match the final span exactly) but should still be better than what we had so far (where the name would always just be e.g.GET).Fixes #12944