From aee64ff52cefdbdae84346740dcc7edd28751266 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Tue, 5 Nov 2024 16:11:14 +0100 Subject: [PATCH 1/2] ref(browser): Reduce bundle size for starting interaction child spans --- packages/browser-utils/src/metrics/browserMetrics.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/browser-utils/src/metrics/browserMetrics.ts b/packages/browser-utils/src/metrics/browserMetrics.ts index 670b1ce4ae25..20fa3884a74e 100644 --- a/packages/browser-utils/src/metrics/browserMetrics.ts +++ b/packages/browser-utils/src/metrics/browserMetrics.ts @@ -192,7 +192,8 @@ export function startTrackingLongAnimationFrames(): void { */ export function startTrackingInteractions(): void { addPerformanceInstrumentationHandler('event', ({ entries }) => { - if (!getActiveSpan()) { + const parent = getActiveSpan(); + if (!parent) { return; } for (const entry of entries) { @@ -218,6 +219,8 @@ export function startTrackingInteractions(): void { if (span) { span.end(startTime + duration); } + + startAndEndSpan(parent, startTime, startTime + duration, spanOptions); } } }); From b650306f27d96d618f75bb3f533a09d4df09f37b Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Tue, 5 Nov 2024 16:12:48 +0100 Subject: [PATCH 2/2] actually reduce lol --- packages/browser-utils/src/metrics/browserMetrics.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/packages/browser-utils/src/metrics/browserMetrics.ts b/packages/browser-utils/src/metrics/browserMetrics.ts index 20fa3884a74e..96eb1207ca2e 100644 --- a/packages/browser-utils/src/metrics/browserMetrics.ts +++ b/packages/browser-utils/src/metrics/browserMetrics.ts @@ -215,11 +215,6 @@ export function startTrackingInteractions(): void { spanOptions.attributes['ui.component_name'] = componentName; } - const span = startInactiveSpan(spanOptions); - if (span) { - span.end(startTime + duration); - } - startAndEndSpan(parent, startTime, startTime + duration, spanOptions); } }