From fa0995e256313fc586aa70409dc8d9e5fe31cf65 Mon Sep 17 00:00:00 2001 From: Zach Kirsch Date: Mon, 30 Jun 2025 11:49:07 -0400 Subject: [PATCH] Don't throw in background promise in withMontior --- packages/core/src/exports.ts | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/packages/core/src/exports.ts b/packages/core/src/exports.ts index 92e4d09d4d81..ea6508ced8b4 100644 --- a/packages/core/src/exports.ts +++ b/packages/core/src/exports.ts @@ -174,21 +174,21 @@ export function withMonitor( throw e; } - if (isThenable(maybePromiseResult)) { - Promise.resolve(maybePromiseResult).then( - () => { - finishCheckIn('ok'); - }, - e => { - finishCheckIn('error'); - throw e; - }, - ); - } else { + if (!isThenable(maybePromiseResult)) { finishCheckIn('ok'); + return maybePromiseResult; } - return maybePromiseResult; + return maybePromiseResult.then( + result => { + finishCheckIn('ok'); + return result; + }, + e => { + finishCheckIn('error'); + throw e; + }, + ) as T; }); }