From f0922b4188f45dbd4fe2fe59ea4b73ab1fcb7ac1 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Thu, 17 Jul 2025 10:31:46 -0400 Subject: [PATCH 1/3] feat(core)!: Remove deprecated logger --- packages/core/src/carrier.ts | 4 -- packages/core/src/index.ts | 6 +-- packages/core/src/utils/debug-logger.ts | 60 ------------------------- 3 files changed, 2 insertions(+), 68 deletions(-) diff --git a/packages/core/src/carrier.ts b/packages/core/src/carrier.ts index 9fde3f7b74f0..201e79cb4514 100644 --- a/packages/core/src/carrier.ts +++ b/packages/core/src/carrier.ts @@ -3,7 +3,6 @@ import type { AsyncContextStrategy } from './asyncContext/types'; import type { Client } from './client'; import type { Scope } from './scope'; import type { SerializedLog } from './types-hoist/log'; -import type { Logger } from './utils/debug-logger'; import { SDK_VERSION } from './utils/version'; import { GLOBAL_OBJ } from './utils/worldwide'; @@ -26,9 +25,6 @@ export interface SentryCarrier { globalScope?: Scope; defaultIsolationScope?: Scope; defaultCurrentScope?: Scope; - /** @deprecated Logger is no longer set. Instead, we keep enabled state in loggerSettings. */ - // eslint-disable-next-line deprecation/deprecation - logger?: Logger; loggerSettings?: { enabled: boolean }; /** * A map of Sentry clients to their log buffers. diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts index 9acecf51d170..282e075e81ff 100644 --- a/packages/core/src/index.ts +++ b/packages/core/src/index.ts @@ -161,10 +161,8 @@ export { isVueViewModel, } from './utils/is'; export { isBrowser } from './utils/isBrowser'; -// eslint-disable-next-line deprecation/deprecation -export { CONSOLE_LEVELS, consoleSandbox, debug, logger, originalConsoleMethods } from './utils/debug-logger'; -// eslint-disable-next-line deprecation/deprecation -export type { Logger, SentryDebugLogger } from './utils/debug-logger'; +export { CONSOLE_LEVELS, consoleSandbox, debug, originalConsoleMethods } from './utils/debug-logger'; +export type { SentryDebugLogger } from './utils/debug-logger'; export { addContextToFrame, addExceptionMechanism, diff --git a/packages/core/src/utils/debug-logger.ts b/packages/core/src/utils/debug-logger.ts index 36e3169b1d52..6fc9c7a8c865 100644 --- a/packages/core/src/utils/debug-logger.ts +++ b/packages/core/src/utils/debug-logger.ts @@ -3,24 +3,6 @@ import { DEBUG_BUILD } from '../debug-build'; import type { ConsoleLevel } from '../types-hoist/instrument'; import { GLOBAL_OBJ } from './worldwide'; -/** - * A Sentry Logger instance. - * - * @deprecated Use {@link debug} instead with the {@link SentryDebugLogger} type. - */ -export interface Logger { - disable(): void; - enable(): void; - isEnabled(): boolean; - log(...args: Parameters): void; - info(...args: Parameters): void; - warn(...args: Parameters): void; - error(...args: Parameters): void; - debug(...args: Parameters): void; - assert(...args: Parameters): void; - trace(...args: Parameters): void; -} - export interface SentryDebugLogger { disable(): void; enable(): void; @@ -115,18 +97,6 @@ function error(...args: Parameters): void { _maybeLog('error', ...args); } -function _debug(...args: Parameters): void { - _maybeLog('debug', ...args); -} - -function assert(...args: Parameters): void { - _maybeLog('assert', ...args); -} - -function trace(...args: Parameters): void { - _maybeLog('trace', ...args); -} - function _maybeLog(level: ConsoleLevel, ...args: Parameters<(typeof console)[typeof level]>): void { if (!DEBUG_BUILD) { return; @@ -147,36 +117,6 @@ function _getLoggerSettings(): { enabled: boolean } { return getGlobalSingleton('loggerSettings', () => ({ enabled: false })); } -/** - * This is a logger singleton which either logs things or no-ops if logging is not enabled. - * The logger is a singleton on the carrier, to ensure that a consistent logger is used throughout the SDK. - * - * @deprecated Use {@link debug} instead. - */ -export const logger = { - /** Enable logging. */ - enable, - /** Disable logging. */ - disable, - /** Check if logging is enabled. */ - isEnabled, - /** Log a message. */ - log, - /** Log level info */ - info, - /** Log a warning. */ - warn, - /** Log an error. */ - error, - /** Log a debug message. */ - debug: _debug, - /** Log an assertion. */ - assert, - /** Log a trace. */ - trace, - // eslint-disable-next-line deprecation/deprecation -} satisfies Logger; - /** * This is a logger singleton which either logs things or no-ops if logging is not enabled. */ From 4a6e552659c3b652e555aa2520abb31396799229 Mon Sep 17 00:00:00 2001 From: Andrei Borza Date: Fri, 18 Jul 2025 10:52:10 +0200 Subject: [PATCH 2/3] Add removal to migration guide --- MIGRATION.md | 1 + 1 file changed, 1 insertion(+) diff --git a/MIGRATION.md b/MIGRATION.md index 9e922dcd731b..d44e53a05f37 100644 --- a/MIGRATION.md +++ b/MIGRATION.md @@ -41,6 +41,7 @@ Updates and fixes for version 9 will be published as `SentryNodeServerlessSDKv9` - `BaseClient` was removed, use `Client` as a direct replacement. - `hasTracingEnabled` was removed, use `hasSpansEnabled` as a direct replacement. +- `logger` and type `Logger` were removed, use `debug` and type `SentryDebugLogger` instead. ## No Version Support Timeline From 4e96f748e594fd3a5f86af91a1eb1b764de0eab0 Mon Sep 17 00:00:00 2001 From: Andrei Borza Date: Fri, 18 Jul 2025 12:34:28 +0200 Subject: [PATCH 3/3] Remove usage of logger from nuxt-3 e2e test app --- .../nuxt-3/server/plugins/customNitroErrorHandler.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dev-packages/e2e-tests/test-applications/nuxt-3/server/plugins/customNitroErrorHandler.ts b/dev-packages/e2e-tests/test-applications/nuxt-3/server/plugins/customNitroErrorHandler.ts index 9ca836610f2f..880b43061b93 100644 --- a/dev-packages/e2e-tests/test-applications/nuxt-3/server/plugins/customNitroErrorHandler.ts +++ b/dev-packages/e2e-tests/test-applications/nuxt-3/server/plugins/customNitroErrorHandler.ts @@ -1,4 +1,4 @@ -import { Context, GLOBAL_OBJ, flush, logger, vercelWaitUntil } from '@sentry/core'; +import { Context, GLOBAL_OBJ, flush, debug, vercelWaitUntil } from '@sentry/core'; import * as SentryNode from '@sentry/node'; import { H3Error } from 'h3'; import type { CapturedErrorContext } from 'nitropack'; @@ -74,10 +74,10 @@ async function flushWithTimeout(): Promise { const isDebug = sentryClient ? sentryClient.getOptions().debug : false; try { - isDebug && logger.log('Flushing events...'); + isDebug && debug.log('Flushing events...'); await flush(2000); - isDebug && logger.log('Done flushing events'); + isDebug && debug.log('Done flushing events'); } catch (e) { - isDebug && logger.log('Error while flushing events:\n', e); + isDebug && debug.log('Error while flushing events:\n', e); } }