From e78ccd8984b10a47f1a72c69966cd9dc964d0b17 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Tue, 25 Jan 2022 20:59:04 -0800 Subject: [PATCH 1/2] update to TS 3.8.3 --- package.json | 2 +- packages/typescript/package.json | 2 +- scripts/verify-packages-versions.js | 2 +- yarn.lock | 8 ++++---- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index 4086bed58ea2..c94c9ab3932c 100644 --- a/package.json +++ b/package.json @@ -75,7 +75,7 @@ "size-limit": "^4.5.5", "ts-jest": "^24.3.0", "typedoc": "^0.18.0", - "typescript": "3.7.5" + "typescript": "3.8.3" }, "resolutions": { "**/agent-base": "5", diff --git a/packages/typescript/package.json b/packages/typescript/package.json index f9b5cea780bc..076e68460522 100644 --- a/packages/typescript/package.json +++ b/packages/typescript/package.json @@ -16,7 +16,7 @@ }, "peerDependencies": { "tslint": "5.16.0", - "typescript": "3.7.5" + "typescript": "3.8.3" }, "scripts": { "link:yarn": "yarn link", diff --git a/scripts/verify-packages-versions.js b/scripts/verify-packages-versions.js index fb6a6e95ec7f..e0efc39311bc 100644 --- a/scripts/verify-packages-versions.js +++ b/scripts/verify-packages-versions.js @@ -1,6 +1,6 @@ const pkg = require('../package.json'); -const TYPESCRIPT_VERSION = '3.7.5'; +const TYPESCRIPT_VERSION = '3.8.3'; if (pkg.devDependencies.typescript !== TYPESCRIPT_VERSION) { console.error(` diff --git a/yarn.lock b/yarn.lock index bbdac1524371..065cd3b6069e 100644 --- a/yarn.lock +++ b/yarn.lock @@ -21065,10 +21065,10 @@ typescript-memoize@^1.0.1: resolved "https://registry.yarnpkg.com/typescript-memoize/-/typescript-memoize-1.0.1.tgz#0a8199aa28f6fe18517f6e9308ef7bfbe9a98d59" integrity sha512-oJNge1qUrOK37d5Y6Ly2txKeuelYVsFtNF6U9kXIN7juudcQaHJQg2MxLOy0CqtkW65rVDYuTCOjnSIVPd8z3w== -typescript@3.7.5: - version "3.7.5" - resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.7.5.tgz#0692e21f65fd4108b9330238aac11dd2e177a1ae" - integrity sha512-/P5lkRXkWHNAbcJIiHPfRoKqyd7bsyCma1hZNUGfn20qm64T6ZBlrzprymeu918H+mB/0rIg2gGK/BXkhhYgBw== +typescript@3.8.3: + version "3.8.3" + resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.8.3.tgz#409eb8544ea0335711205869ec458ab109ee1061" + integrity sha512-MYlEfn5VrLNsgudQTVJeNaQFUAI7DkhnOjdpAp4T+ku1TfQClewlbSuTVHiA+8skNBgaf02TL/kLOvig4y3G8w== typescript@^3.9.5, typescript@^3.9.7: version "3.9.9" From 8bdd1c45209eff0ee5b41cb0468fd094fc844638 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Wed, 2 Feb 2022 12:39:13 -0800 Subject: [PATCH 2/2] explicitly await async operations in browser integration tests --- .../tracing/browsertracing/backgroundtab-pageload/test.ts | 2 +- .../suites/tracing/metrics/web-vitals-fid/test.ts | 4 ++-- .../suites/tracing/metrics/web-vitals-lcp/test.ts | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/integration-tests/suites/tracing/browsertracing/backgroundtab-pageload/test.ts b/packages/integration-tests/suites/tracing/browsertracing/backgroundtab-pageload/test.ts index d33af7a0ba03..c03757225ee3 100644 --- a/packages/integration-tests/suites/tracing/browsertracing/backgroundtab-pageload/test.ts +++ b/packages/integration-tests/suites/tracing/browsertracing/backgroundtab-pageload/test.ts @@ -8,7 +8,7 @@ sentryTest('should finish pageload transaction when the page goes background', a await page.goto(url); - page.click('#go-background'); + void page.click('#go-background'); const pageloadTransaction = await getSentryTransactionRequest(page); diff --git a/packages/integration-tests/suites/tracing/metrics/web-vitals-fid/test.ts b/packages/integration-tests/suites/tracing/metrics/web-vitals-fid/test.ts index ebf514381d3d..fe424944453f 100644 --- a/packages/integration-tests/suites/tracing/metrics/web-vitals-fid/test.ts +++ b/packages/integration-tests/suites/tracing/metrics/web-vitals-fid/test.ts @@ -11,9 +11,9 @@ sentryTest('should capture a FID vital.', async ({ browserName, getLocalTestPath const url = await getLocalTestPath({ testDir: __dirname }); - page.goto(url); + await page.goto(url); // To trigger FID - page.click('#fid-btn'); + await page.click('#fid-btn'); const eventData = await getSentryTransactionRequest(page); diff --git a/packages/integration-tests/suites/tracing/metrics/web-vitals-lcp/test.ts b/packages/integration-tests/suites/tracing/metrics/web-vitals-lcp/test.ts index a5b5360945d2..ed82a8f6776b 100644 --- a/packages/integration-tests/suites/tracing/metrics/web-vitals-lcp/test.ts +++ b/packages/integration-tests/suites/tracing/metrics/web-vitals-lcp/test.ts @@ -13,10 +13,10 @@ sentryTest('should capture a LCP vital with element details.', async ({ browserN ); const url = await getLocalTestPath({ testDir: __dirname }); - page.goto(url); + await page.goto(url); // Force closure of LCP listener. - page.click('body'); + await page.click('body'); const eventData = await getSentryTransactionRequest(page); expect(eventData.measurements).toBeDefined();